Remove unnecessary casts in free() and pfree()

petere · petere · commit 45987aae260a · 2022-08-26T15:55:57.000+02:00
Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us> Discussion: https://www.postgresql.org/message-id/flat/cf26e970-8e92-59f1-247a-aa265235075b%40enterprisedb.com
diff --git a/contrib/sepgsql/label.c b/contrib/sepgsql/label.c
@@ -662,28 +662,28 @@ quote_object_name(const char *src1, const char *src2,
 		temp = quote_identifier(src1);
 		appendStringInfoString(&result, temp);
 		if (src1 != temp)
-			pfree((void *) temp);
+			pfree(temp);
 	}
 	if (src2)
 	{
 		temp = quote_identifier(src2);
 		appendStringInfo(&result, ".%s", temp);
 		if (src2 != temp)
-			pfree((void *) temp);
+			pfree(temp);
 	}
 	if (src3)
 	{
 		temp = quote_identifier(src3);
 		appendStringInfo(&result, ".%s", temp);
 		if (src3 != temp)
-			pfree((void *) temp);
+			pfree(temp);
 	}
 	if (src4)
 	{
 		temp = quote_identifier(src4);
 		appendStringInfo(&result, ".%s", temp);
 		if (src4 != temp)
-			pfree((void *) temp);
+			pfree(temp);
 	}
 	return result.data;
 }
diff --git a/src/backend/utils/fmgr/dfmgr.c b/src/backend/utils/fmgr/dfmgr.c
@@ -240,7 +240,7 @@ internal_load_library(const char *libname)
 		if (file_scanner->handle == NULL)
 		{
 			load_error = dlerror();
-			free((char *) file_scanner);
+			free(file_scanner);
 			/* errcode_for_file_access might not be appropriate here? */
 			ereport(ERROR,
 					(errcode_for_file_access(),
@@ -263,7 +263,7 @@ internal_load_library(const char *libname)
 
 				/* try to close library */
 				dlclose(file_scanner->handle);
-				free((char *) file_scanner);
+				free(file_scanner);
 
 				/* issue suitable complaint */
 				incompatible_module_error(libname, &module_magic_data);
@@ -273,7 +273,7 @@ internal_load_library(const char *libname)
 		{
 			/* try to close library */
 			dlclose(file_scanner->handle);
-			free((char *) file_scanner);
+			free(file_scanner);
 			/* complain */
 			ereport(ERROR,
 					(errmsg("incompatible library \"%s\": missing magic block",

Original file line number	Diff line number	Diff line change
`@@ -662,28 +662,28 @@ quote_object_name(const char src1, const char src2,`
`662`	`662`	`temp = quote_identifier(src1);`
`663`	`663`	`appendStringInfoString(&result, temp);`
`664`	`664`	`if (src1 != temp)`
`665`		`- pfree((void *) temp);`
	`665`	`+ pfree(temp);`
`666`	`666`	`}`
`667`	`667`	`if (src2)`
`668`	`668`	`{`
`669`	`669`	`temp = quote_identifier(src2);`
`670`	`670`	`appendStringInfo(&result, ".%s", temp);`
`671`	`671`	`if (src2 != temp)`
`672`		`- pfree((void *) temp);`
	`672`	`+ pfree(temp);`
`673`	`673`	`}`
`674`	`674`	`if (src3)`
`675`	`675`	`{`
`676`	`676`	`temp = quote_identifier(src3);`
`677`	`677`	`appendStringInfo(&result, ".%s", temp);`
`678`	`678`	`if (src3 != temp)`
`679`		`- pfree((void *) temp);`
	`679`	`+ pfree(temp);`
`680`	`680`	`}`
`681`	`681`	`if (src4)`
`682`	`682`	`{`
`683`	`683`	`temp = quote_identifier(src4);`
`684`	`684`	`appendStringInfo(&result, ".%s", temp);`
`685`	`685`	`if (src4 != temp)`
`686`		`- pfree((void *) temp);`
	`686`	`+ pfree(temp);`
`687`	`687`	`}`
`688`	`688`	`return result.data;`
`689`	`689`	`}`