Fix resource leak pointed out by Coverity.

tatsuo-ishii · tatsuo-ishii · commit 4db7eaae0f1a · 2014-12-30T19:59:26.000+09:00
diff --git a/contrib/pgbench/pgbench.c b/contrib/pgbench/pgbench.c
@@ -1473,6 +1473,7 @@ parseQuery(Command *cmd, const char *raw_sql)
 
 		if (cmd->argc >= MAX_ARGS)
 		{
+			free(name);
 			fprintf(stderr, "statement has too many arguments (maximum is %d): %s\n", MAX_ARGS - 1, raw_sql);
 			return false;
 		}
@@ -1670,6 +1671,7 @@ process_file(char *filename)
 		fd = stdin;
 	else if ((fd = fopen(filename, "r")) == NULL)
 	{
+		free(my_commands);
 		fprintf(stderr, "%s: %s\n", filename, strerror(errno));
 		return false;
 	}

Original file line number	Diff line number	Diff line change
`@@ -1473,6 +1473,7 @@ parseQuery(Command cmd, const char raw_sql)`
`1473`	`1473`
`1474`	`1474`	`if (cmd->argc >= MAX_ARGS)`
`1475`	`1475`	`{`
	`1476`	`+ free(name);`
`1476`	`1477`	`fprintf(stderr, "statement has too many arguments (maximum is %d): %s\n", MAX_ARGS - 1, raw_sql);`
`1477`	`1478`	`return false;`
`1478`	`1479`	`}`
`@@ -1670,6 +1671,7 @@ process_file(char *filename)`
`1670`	`1671`	`fd = stdin;`
`1671`	`1672`	`else if ((fd = fopen(filename, "r")) == NULL)`
`1672`	`1673`	`{`
	`1674`	`+ free(my_commands);`
`1673`	`1675`	`fprintf(stderr, "%s: %s\n", filename, strerror(errno));`
`1674`	`1676`	`return false;`
`1675`	`1677`	`}`