Use correct format placeholder for pids

petere · petere · commit 640b91c3ed24 · 2021-04-19T10:43:18.000+02:00
Should be signed, not unsigned.
diff --git a/src/backend/postmaster/autovacuum.c b/src/backend/postmaster/autovacuum.c
@@ -1860,7 +1860,7 @@ autovac_balance_cost(void)
 		}
 
 		if (worker->wi_proc != NULL)
-			elog(DEBUG2, "autovac_balance_cost(pid=%u db=%u, rel=%u, dobalance=%s cost_limit=%d, cost_limit_base=%d, cost_delay=%g)",
+			elog(DEBUG2, "autovac_balance_cost(pid=%d db=%u, rel=%u, dobalance=%s cost_limit=%d, cost_limit_base=%d, cost_delay=%g)",
 				 worker->wi_proc->pid, worker->wi_dboid, worker->wi_tableoid,
 				 worker->wi_dobalance ? "yes" : "no",
 				 worker->wi_cost_limit, worker->wi_cost_limit_base,
diff --git a/src/backend/postmaster/bgworker.c b/src/backend/postmaster/bgworker.c
@@ -387,7 +387,7 @@ BackgroundWorkerStateChange(bool allow_new_workers)
 		rw->rw_worker.bgw_notify_pid = slot->worker.bgw_notify_pid;
 		if (!PostmasterMarkPIDForWorkerNotify(rw->rw_worker.bgw_notify_pid))
 		{
-			elog(DEBUG1, "worker notification PID %lu is not valid",
+			elog(DEBUG1, "worker notification PID %ld is not valid",
 				 (long) rw->rw_worker.bgw_notify_pid);
 			rw->rw_worker.bgw_notify_pid = 0;
 		}
diff --git a/src/backend/replication/logical/snapbuild.c b/src/backend/replication/logical/snapbuild.c
@@ -1541,7 +1541,7 @@ SnapBuildSerialize(SnapBuild *builder, XLogRecPtr lsn)
 	elog(DEBUG1, "serializing snapshot to %s", path);
 
 	/* to make sure only we will write to this tempfile, include pid */
-	sprintf(tmppath, "pg_logical/snapshots/%X-%X.snap.%u.tmp",
+	sprintf(tmppath, "pg_logical/snapshots/%X-%X.snap.%d.tmp",
 			LSN_FORMAT_ARGS(lsn), MyProcPid);
 
 	/*

Original file line number	Diff line number	Diff line change
`@@ -1860,7 +1860,7 @@ autovac_balance_cost(void)`
`1860`	`1860`	`}`
`1861`	`1861`
`1862`	`1862`	`if (worker->wi_proc != NULL)`
`1863`		`- elog(DEBUG2, "autovac_balance_cost(pid=%u db=%u, rel=%u, dobalance=%s cost_limit=%d, cost_limit_base=%d, cost_delay=%g)",`
	`1863`	`+ elog(DEBUG2, "autovac_balance_cost(pid=%d db=%u, rel=%u, dobalance=%s cost_limit=%d, cost_limit_base=%d, cost_delay=%g)",`
`1864`	`1864`	`worker->wi_proc->pid, worker->wi_dboid, worker->wi_tableoid,`
`1865`	`1865`	`worker->wi_dobalance ? "yes" : "no",`
`1866`	`1866`	`worker->wi_cost_limit, worker->wi_cost_limit_base,`
Original file line number	Diff line number	Diff line change
`@@ -387,7 +387,7 @@ BackgroundWorkerStateChange(bool allow_new_workers)`
`387`	`387`	`rw->rw_worker.bgw_notify_pid = slot->worker.bgw_notify_pid;`
`388`	`388`	`if (!PostmasterMarkPIDForWorkerNotify(rw->rw_worker.bgw_notify_pid))`
`389`	`389`	`{`
`390`		`- elog(DEBUG1, "worker notification PID %lu is not valid",`
	`390`	`+ elog(DEBUG1, "worker notification PID %ld is not valid",`
`391`	`391`	`(long) rw->rw_worker.bgw_notify_pid);`
`392`	`392`	`rw->rw_worker.bgw_notify_pid = 0;`
`393`	`393`	`}`