Fix for memory leak from Denis Perchine

bmomjian · bmomjian · commit 69cd08d9f798 · 2000-06-14T04:53:44.000Z
diff --git a/src/backend/catalog/pg_proc.c b/src/backend/catalog/pg_proc.c
@@ -8,7 +8,7 @@
  *
  *
  * IDENTIFICATION
- *	  $Header: /cvsroot/pgsql/src/backend/catalog/pg_proc.c,v 1.43 2000/05/28 17:55:54 tgl Exp $
+ *	  $Header: /cvsroot/pgsql/src/backend/catalog/pg_proc.c,v 1.44 2000/06/14 04:53:44 momjian Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -67,6 +67,7 @@ ProcedureCreate(char *procedureName,
 	Oid			toid;
 	NameData	procname;
 	TupleDesc	tupDesc;
+	Oid		retval;
 
 	/* ----------------
 	 *	sanity checks
@@ -327,5 +328,7 @@ ProcedureCreate(char *procedureName,
 		CatalogCloseIndices(Num_pg_proc_indices, idescs);
 	}
 	heap_close(rel, RowExclusiveLock);
-	return tup->t_data->t_oid;
+	retval = tup->t_data->t_oid;
+	heap_freetuple(tup);
+	return retval;
 }

Original file line number	Diff line number	Diff line change
`@@ -8,7 +8,7 @@`
`8`	`8`	`*`
`9`	`9`	`*`
`10`	`10`	`* IDENTIFICATION`
`11`		`- * $Header: /cvsroot/pgsql/src/backend/catalog/pg_proc.c,v 1.43 2000/05/28 17:55:54 tgl Exp $`
	`11`	`+ * $Header: /cvsroot/pgsql/src/backend/catalog/pg_proc.c,v 1.44 2000/06/14 04:53:44 momjian Exp $`
`12`	`12`	`*`
`13`	`13`	`*-------------------------------------------------------------------------`
`14`	`14`	`*/`
`@@ -67,6 +67,7 @@ ProcedureCreate(char *procedureName,`
`67`	`67`	`Oid toid;`
`68`	`68`	`NameData procname;`
`69`	`69`	`TupleDesc tupDesc;`
	`70`	`+ Oid retval;`
`70`	`71`
`71`	`72`	`/* ----------------`
`72`	`73`	`* sanity checks`
`@@ -327,5 +328,7 @@ ProcedureCreate(char *procedureName,`
`327`	`328`	`CatalogCloseIndices(Num_pg_proc_indices, idescs);`
`328`	`329`	`}`
`329`	`330`	`heap_close(rel, RowExclusiveLock);`
`330`		`- return tup->t_data->t_oid;`
	`331`	`+ retval = tup->t_data->t_oid;`
	`332`	`+ heap_freetuple(tup);`
	`333`	`+ return retval;`
`331`	`334`	`}`