Portability fix for old SunOS releases: fflush(NULL)

tglsfdc · tglsfdc · commit 79fcde48b229 · 1998-11-29T01:51:56.000Z
doesn't work there.  Fortunately the postmaster only has stdout and
stderr to flush.
diff --git a/src/backend/postmaster/postmaster.c b/src/backend/postmaster/postmaster.c
@@ -10,7 +10,7 @@
  *
  *
  * IDENTIFICATION
- *	  $Header: /cvsroot/pgsql/src/backend/postmaster/postmaster.c,v 1.97 1998/09/01 04:31:21 momjian Exp $
+ *	  $Header: /cvsroot/pgsql/src/backend/postmaster/postmaster.c,v 1.98 1998/11/29 01:51:56 tgl Exp $
  *
  * NOTES
  *
@@ -1289,10 +1289,14 @@ BackendStartup(Port *port)
 	}
 
 	/*
-	 * Flush all stdio channels just before fork, to avoid double-output
-	 * problems.
+	 * Flush stdio channels just before fork, to avoid double-output problems.
+	 * Ideally we'd use fflush(NULL) here, but there are still a few non-ANSI
+	 * stdio libraries out there (like SunOS 4.1.x) that coredump if we do.
+	 * Presently stdout and stderr are the only stdio output channels used
+	 * by the postmaster, so fflush'ing them should be sufficient.
 	 */
-	fflush(NULL);
+	fflush(stdout);
+	fflush(stderr);
 
 	if ((pid = fork()) == 0)
 	{							/* child */

Original file line number	Diff line number	Diff line change
`@@ -10,7 +10,7 @@`
`10`	`10`	`*`
`11`	`11`	`*`
`12`	`12`	`* IDENTIFICATION`
`13`		`- * $Header: /cvsroot/pgsql/src/backend/postmaster/postmaster.c,v 1.97 1998/09/01 04:31:21 momjian Exp $`
	`13`	`+ * $Header: /cvsroot/pgsql/src/backend/postmaster/postmaster.c,v 1.98 1998/11/29 01:51:56 tgl Exp $`
`14`	`14`	`*`
`15`	`15`	`* NOTES`
`16`	`16`	`*`
`@@ -1289,10 +1289,14 @@ BackendStartup(Port *port)`
`1289`	`1289`	`}`
`1290`	`1290`
`1291`	`1291`	`/*`
`1292`		`- * Flush all stdio channels just before fork, to avoid double-output`
`1293`		`- * problems.`
	`1292`	`+ * Flush stdio channels just before fork, to avoid double-output problems.`
	`1293`	`+ * Ideally we'd use fflush(NULL) here, but there are still a few non-ANSI`
	`1294`	`+ * stdio libraries out there (like SunOS 4.1.x) that coredump if we do.`
	`1295`	`+ * Presently stdout and stderr are the only stdio output channels used`
	`1296`	`+ * by the postmaster, so fflush'ing them should be sufficient.`
`1294`	`1297`	`*/`
`1295`		`- fflush(NULL);`
	`1298`	`+ fflush(stdout);`
	`1299`	`+ fflush(stderr);`
`1296`	`1300`
`1297`	`1301`	`if ((pid = fork()) == 0)`
`1298`	`1302`	`{ /* child */`