Compare varnullingrels too in assign_param_for_var().

tglsfdc · tglsfdc · commit 807369d80384 · 2024-01-26T15:54:17.000-05:00
Oversight in 2489d76. Preliminary analysis suggests that the problem may be unreachable --- but if we did have instances of the same column with different varnullingrels, we'd surely need to treat them as different Params. Discussion: https://postgr.es/m/412552.1706203379@sss.pgh.pa.us
diff --git a/src/backend/optimizer/util/paramassign.c b/src/backend/optimizer/util/paramassign.c
@@ -90,7 +90,8 @@ assign_param_for_var(PlannerInfo *root, Var *var)
 				pvar->varattno == var->varattno &&
 				pvar->vartype == var->vartype &&
 				pvar->vartypmod == var->vartypmod &&
-				pvar->varcollid == var->varcollid)
+				pvar->varcollid == var->varcollid &&
+				bms_equal(pvar->varnullingrels, var->varnullingrels))
 				return pitem->paramId;
 		}
 	}

Original file line number	Diff line number	Diff line change
`@@ -90,7 +90,8 @@ assign_param_for_var(PlannerInfo root, Var var)`
`90`	`90`	`pvar->varattno == var->varattno &&`
`91`	`91`	`pvar->vartype == var->vartype &&`
`92`	`92`	`pvar->vartypmod == var->vartypmod &&`
`93`		`- pvar->varcollid == var->varcollid)`
	`93`	`+ pvar->varcollid == var->varcollid &&`
	`94`	`+ bms_equal(pvar->varnullingrels, var->varnullingrels))`
`94`	`95`	`return pitem->paramId;`
`95`	`96`	`}`
`96`	`97`	`}`