Remove dead code from _bt_update_posting().

petergeoghegan · petergeoghegan · commit 84ec9b231a86 · 2020-03-01T12:11:26.000-08:00
Discussion: https://postgr.es/m/CAH2-WzmAufHiOku6AGiFD=81VQs5nYJ1L2YkhW1t+BH4CMsgRw@mail.gmail.com
diff --git a/src/backend/access/nbtree/nbtdedup.c b/src/backend/access/nbtree/nbtdedup.c
@@ -674,18 +674,14 @@ _bt_update_posting(BTVacuumPosting vacposting)
 	Assert(_bt_posting_valid(origtuple));
 	Assert(nhtids > 0 && nhtids < BTreeTupleGetNPosting(origtuple));
 
-	if (BTreeTupleIsPosting(origtuple))
-		keysize = BTreeTupleGetPostingOffset(origtuple);
-	else
-		keysize = IndexTupleSize(origtuple);
-
 	/*
 	 * Determine final size of new tuple.
 	 *
 	 * This calculation needs to match the code used within _bt_form_posting()
 	 * for new posting list tuples.  We avoid calling _bt_form_posting() here
 	 * to save ourselves a second memory allocation for a htids workspace.
 	 */
+	keysize = BTreeTupleGetPostingOffset(origtuple);
 	if (nhtids > 1)
 		newsize = MAXALIGN(keysize +
 						   nhtids * sizeof(ItemPointerData));
