Plug memory leak in index_get_partition

alvherre · alvherre · commit 8ad6a0c1bb1c · 2020-11-06T22:52:15.000-03:00
The list of indexes was being leaked when asked for an index that doesn't have an index partition in the table partition. Not a common case admittedly --and in most cases where it occurs, caller throws an error anyway-- but worth fixing for cleanliness and in case any third-party code is calling this function. While at it, remove use of lfirst_oid() to obtain a value we already have. Author: Justin Pryzby <pryzby@telsasoft.com> Reviewed-by: Michael Paquier <michael@paquier.xyz> Discussion: https://postgr.es/m/20201105203606.GF22691@telsasoft.com
diff --git a/src/backend/catalog/partition.c b/src/backend/catalog/partition.c
@@ -171,13 +171,14 @@ index_get_partition(Relation partition, Oid indexId)
 		ReleaseSysCache(tup);
 		if (!ispartition)
 			continue;
-		if (get_partition_parent(lfirst_oid(l)) == indexId)
+		if (get_partition_parent(partIdx) == indexId)
 		{
 			list_free(idxlist);
 			return partIdx;
 		}
 	}
 
+	list_free(idxlist);
 	return InvalidOid;
 }
 

Original file line number	Diff line number	Diff line change
`@@ -171,13 +171,14 @@ index_get_partition(Relation partition, Oid indexId)`
`171`	`171`	`ReleaseSysCache(tup);`
`172`	`172`	`if (!ispartition)`
`173`	`173`	`continue;`
`174`		`- if (get_partition_parent(lfirst_oid(l)) == indexId)`
	`174`	`+ if (get_partition_parent(partIdx) == indexId)`
`175`	`175`	`{`
`176`	`176`	`list_free(idxlist);`
`177`	`177`	`return partIdx;`
`178`	`178`	`}`
`179`	`179`	`}`
`180`	`180`
	`181`	`+ list_free(idxlist);`
`181`	`182`	`return InvalidOid;`
`182`	`183`	`}`
`183`	`184`