Fix small memory leak in psql's \bind command

michaelpq · michaelpq · commit 8bf5af2ee6ea · 2023-02-22T14:22:13.000+09:00
psql_scan_slash_option() returns a malloc()'d result through a PQExpBuffer, and exec_command_bind() was doing an extra allocation of this option for no effect. Introduced in 5b66de3. Author: Kyotaro Horiguchi Reviewed-by: Corey Huinker Discussion: https://postgr.es/m/20230221.115555.89096938631423206.horikyota.ntt@gmail.com
diff --git a/src/bin/psql/command.c b/src/bin/psql/command.c
@@ -480,7 +480,7 @@ exec_command_bind(PsqlScanState scan_state, bool active_branch)
 				nalloc = nalloc ? nalloc * 2 : 1;
 				pset.bind_params = pg_realloc_array(pset.bind_params, char *, nalloc);
 			}
-			pset.bind_params[nparams - 1] = pg_strdup(opt);
+			pset.bind_params[nparams - 1] = opt;
 		}
 
 		pset.bind_nparams = nparams;

Original file line number	Diff line number	Diff line change
`@@ -480,7 +480,7 @@ exec_command_bind(PsqlScanState scan_state, bool active_branch)`
`480`	`480`	`nalloc = nalloc ? nalloc * 2 : 1;`
`481`	`481`	`pset.bind_params = pg_realloc_array(pset.bind_params, char *, nalloc);`
`482`	`482`	`}`
`483`		`- pset.bind_params[nparams - 1] = pg_strdup(opt);`
	`483`	`+ pset.bind_params[nparams - 1] = opt;`
`484`	`484`	`}`
`485`	`485`
`486`	`486`	`pset.bind_nparams = nparams;`