Correct error message for row-level triggers with transition tables on partitioned tables.

Etsuro Fujita · Etsuro Fujita · commit 8c7146790811 · 2022-11-04T19:15:00.000+09:00
"Triggers on partitioned tables cannot have transition tables." is incorrect as we allow statement-level triggers on partitioned tables to have transition tables. This has been wrong since commit 86f5759; back-patch to v11 where that commit came in. Reviewed by Tom Lane. Discussion: https://postgr.es/m/CAPmGK17gk4vXLzz2iG%2BG4LWRWCoVyam70nZ3OuGm1hMJwDrhcg%40mail.gmail.com
diff --git a/src/backend/commands/trigger.c b/src/backend/commands/trigger.c
@@ -264,7 +264,7 @@ CreateTriggerFiringOn(CreateTrigStmt *stmt, const char *queryString,
 						(errcode(ERRCODE_FEATURE_NOT_SUPPORTED),
 						 errmsg("\"%s\" is a partitioned table",
 								RelationGetRelationName(rel)),
-						 errdetail("Triggers on partitioned tables cannot have transition tables.")));
+						 errdetail("ROW triggers with transition tables are not supported on partitioned tables.")));
 		}
 	}
 	else if (rel->rd_rel->relkind == RELKIND_VIEW)
diff --git a/src/test/regress/expected/triggers.out b/src/test/regress/expected/triggers.out
@@ -2046,7 +2046,7 @@ create trigger failed after update on parted_trig
   referencing old table as old_table
   for each row execute procedure trigger_nothing();
 ERROR:  "parted_trig" is a partitioned table
-DETAIL:  Triggers on partitioned tables cannot have transition tables.
+DETAIL:  ROW triggers with transition tables are not supported on partitioned tables.
 drop table parted_trig;
 --
 -- Verify trigger creation for partitioned tables, and drop behavior

Original file line number	Diff line number	Diff line change
`@@ -264,7 +264,7 @@ CreateTriggerFiringOn(CreateTrigStmt stmt, const char queryString,`
`264`	`264`	`(errcode(ERRCODE_FEATURE_NOT_SUPPORTED),`
`265`	`265`	`errmsg("\"%s\" is a partitioned table",`
`266`	`266`	`RelationGetRelationName(rel)),`
`267`		`- errdetail("Triggers on partitioned tables cannot have transition tables.")));`
	`267`	`+ errdetail("ROW triggers with transition tables are not supported on partitioned tables.")));`
`268`	`268`	`}`
`269`	`269`	`}`
`270`	`270`	`else if (rel->rd_rel->relkind == RELKIND_VIEW)`