simplehash: Free collisions array in SH_STAT

anarazel · anarazel · commit 974374dcd394 · 2024-04-07T19:09:02.000-07:00
While SH_STAT() is only used for debugging, the allocated array can be large, and therefore should be freed. It's unclear why coverity started warning now. Reported-by: Tom Lane <tgl@sss.pgh.pa.us> Reported-by: Coverity Discussion: https://postgr.es/m/3005248.1712538233@sss.pgh.pa.us Backpatch: 12-
diff --git a/src/include/lib/simplehash.h b/src/include/lib/simplehash.h
@@ -1101,6 +1101,9 @@ SH_STAT(SH_TYPE * tb)
 			max_collisions = curcoll;
 	}
 
+	/* large enough to be worth freeing, even if just used for debugging */
+	pfree(collisions);
+
 	if (tb->members > 0)
 	{
 		fillfactor = tb->members / ((double) tb->size);

Original file line number	Diff line number	Diff line change
`@@ -1101,6 +1101,9 @@ SH_STAT(SH_TYPE * tb)`
`1101`	`1101`	`max_collisions = curcoll;`
`1102`	`1102`	`}`
`1103`	`1103`
	`1104`	`+ /* large enough to be worth freeing, even if just used for debugging */`
	`1105`	`+ pfree(collisions);`
	`1106`	`+`
`1104`	`1107`	`if (tb->members > 0)`
`1105`	`1108`	`{`
`1106`	`1109`	`fillfactor = tb->members / ((double) tb->size);`