Move variable increment to the end of the loop

j-naylor · j-naylor · commit 995a9fb14f6a · 2022-12-20T14:13:14.000+07:00
This is less error prone and matches the placement of other code in the file. Justin Pryzby Reviewed by Tom Lane Discussion: https://www.postgresql.org/message-id/20221123172436.GJ11463@telsasoft.com
diff --git a/src/backend/utils/activity/backend_status.c b/src/backend/utils/activity/backend_status.c
@@ -842,7 +842,6 @@ pgstat_read_current_status(void)
 			CHECK_FOR_INTERRUPTS();
 		}
 
-		beentry++;
 		/* Only valid entries get included into the local array */
 		if (localentry->backendStatus.st_procpid > 0)
 		{
@@ -871,6 +870,8 @@ pgstat_read_current_status(void)
 #endif
 			localNumBackends++;
 		}
+
+		beentry++;
 	}
 
 	/* Set the pointer only after completion of a valid table */

Original file line number	Diff line number	Diff line change
`@@ -842,7 +842,6 @@ pgstat_read_current_status(void)`
`842`	`842`	`CHECK_FOR_INTERRUPTS();`
`843`	`843`	`}`
`844`	`844`
`845`		`- beentry++;`
`846`	`845`	`/* Only valid entries get included into the local array */`
`847`	`846`	`if (localentry->backendStatus.st_procpid > 0)`
`848`	`847`	`{`
`@@ -871,6 +870,8 @@ pgstat_read_current_status(void)`
`871`	`870`	`#endif`
`872`	`871`	`localNumBackends++;`
`873`	`872`	`}`
	`873`	`+`
	`874`	`+ beentry++;`
`874`	`875`	`}`
`875`	`876`
`876`	`877`	`/* Set the pointer only after completion of a valid table */`