Fix minor coding error: don't ReleaseSysCache until after last use of

tglsfdc · tglsfdc · commit a28375140c6d · 2002-07-29T20:45:44.000Z
cache entry.
diff --git a/src/backend/commands/functioncmds.c b/src/backend/commands/functioncmds.c
@@ -9,7 +9,7 @@
  *
  *
  * IDENTIFICATION
- *	  $Header: /cvsroot/pgsql/src/backend/commands/functioncmds.c,v 1.13 2002/07/24 19:11:09 petere Exp $
+ *	  $Header: /cvsroot/pgsql/src/backend/commands/functioncmds.c,v 1.14 2002/07/29 20:45:44 tgl Exp $
  *
  * DESCRIPTION
  *	  These routines take the parse tree and pick out the
@@ -764,15 +764,15 @@ DropCast(DropCastStmt *stmt)
 			elog(ERROR, "permission denied");
 	}
 
-	ReleaseSysCache(tuple);
-
 	/*
 	 * Do the deletion
 	 */
 	object.classId = get_system_catalog_relid(CastRelationName);
 	object.objectId = HeapTupleGetOid(tuple);
 	object.objectSubId = 0;
 
+	ReleaseSysCache(tuple);
+
 	performDeletion(&object, stmt->behavior);
 }
 

Original file line number	Diff line number	Diff line change
`@@ -9,7 +9,7 @@`
`9`	`9`	`*`
`10`	`10`	`*`
`11`	`11`	`* IDENTIFICATION`
`12`		`- * $Header: /cvsroot/pgsql/src/backend/commands/functioncmds.c,v 1.13 2002/07/24 19:11:09 petere Exp $`
	`12`	`+ * $Header: /cvsroot/pgsql/src/backend/commands/functioncmds.c,v 1.14 2002/07/29 20:45:44 tgl Exp $`
`13`	`13`	`*`
`14`	`14`	`* DESCRIPTION`
`15`	`15`	`* These routines take the parse tree and pick out the`
`@@ -764,15 +764,15 @@ DropCast(DropCastStmt *stmt)`
`764`	`764`	`elog(ERROR, "permission denied");`
`765`	`765`	`}`
`766`	`766`
`767`		`- ReleaseSysCache(tuple);`
`768`		`-`
`769`	`767`	`/*`
`770`	`768`	`* Do the deletion`
`771`	`769`	`*/`
`772`	`770`	`object.classId = get_system_catalog_relid(CastRelationName);`
`773`	`771`	`object.objectId = HeapTupleGetOid(tuple);`
`774`	`772`	`object.objectSubId = 0;`
`775`	`773`
	`774`	`+ ReleaseSysCache(tuple);`
	`775`	`+`
`776`	`776`	`performDeletion(&object, stmt->behavior);`
`777`	`777`	`}`
`778`	`778`