This patch fixes shared_preload_libraries on Windows hosts. It forces

bmomjian · bmomjian · commit a37b006d89b8 · 2007-02-08T15:46:04.000Z
ach backend to re-load all shared_preload_libraries.

Korry Douglas
diff --git a/doc/src/sgml/config.sgml b/doc/src/sgml/config.sgml
@@ -1,4 +1,4 @@
-<!-- $PostgreSQL: pgsql/doc/src/sgml/config.sgml,v 1.109 2007/02/08 03:56:42 momjian Exp $ -->
+<!-- $PostgreSQL: pgsql/doc/src/sgml/config.sgml,v 1.110 2007/02/08 15:46:03 momjian Exp $ -->
 
 <chapter Id="runtime-config">
   <title>Server Configuration</title>
@@ -990,6 +990,17 @@ SET ENABLE_SEQSCAN TO OFF;
         libraries that will be used in most sessions. 
        </para>
 
+     <note>
+      <para>
+        On Windows hosts, preloading a library at server start will not reduce
+        the time required to start each new server process; each server process
+        will re-load all preload libraries.  However, <varname>shared_preload_libraries
+        </varname> is still useful on Windows hosts because some shared libraries may 
+        need to perform certain operations that only take place at postmaster start
+        (for example, a shared library may need to reserve lightweight locks
+        or shared memory and you can't do that after the postmaster has started).
+       </para>
+      </note>
        <para>
         If a specified library is not found,
         the server will fail to start.
diff --git a/src/backend/postmaster/postmaster.c b/src/backend/postmaster/postmaster.c
@@ -37,7 +37,7 @@
  *
  *
  * IDENTIFICATION
- *	  $PostgreSQL: pgsql/src/backend/postmaster/postmaster.c,v 1.517 2007/02/07 16:44:48 tgl Exp $
+ *	  $PostgreSQL: pgsql/src/backend/postmaster/postmaster.c,v 1.518 2007/02/08 15:46:04 momjian Exp $
  *
  * NOTES
  *
@@ -3360,6 +3360,15 @@ SubPostmasterMain(int argc, char *argv[])
 			secure_initialize();
 #endif
 
+		/*
+		 * process any libraries that should be preloaded at postmaster start
+		 *
+		 * NOTE: we have to re-load the shared_preload_libraries here because
+		 * 		 this backend is not fork()ed so we can't inherit any shared
+		 *		 libraries / DLL's from our parent (the postmaster).
+		 */
+		process_shared_preload_libraries();
+
 		/*
 		 * Perform additional initialization and client authentication.
 		 *

Original file line number	Diff line number	Diff line change
`@@ -37,7 +37,7 @@`
`37`	`37`	`*`
`38`	`38`	`*`
`39`	`39`	`* IDENTIFICATION`
`40`		`- * $PostgreSQL: pgsql/src/backend/postmaster/postmaster.c,v 1.517 2007/02/07 16:44:48 tgl Exp $`
	`40`	`+ * $PostgreSQL: pgsql/src/backend/postmaster/postmaster.c,v 1.518 2007/02/08 15:46:04 momjian Exp $`
`41`	`41`	`*`
`42`	`42`	`* NOTES`
`43`	`43`	`*`
`@@ -3360,6 +3360,15 @@ SubPostmasterMain(int argc, char *argv[])`
`3360`	`3360`	`secure_initialize();`
`3361`	`3361`	`#endif`
`3362`	`3362`
	`3363`	`+ /*`
	`3364`	`+ * process any libraries that should be preloaded at postmaster start`
	`3365`	`+ *`
	`3366`	`+ * NOTE: we have to re-load the shared_preload_libraries here because`
	`3367`	`+ * this backend is not fork()ed so we can't inherit any shared`
	`3368`	`+ * libraries / DLL's from our parent (the postmaster).`
	`3369`	`+ */`
	`3370`	`+ process_shared_preload_libraries();`
	`3371`	`+`
`3363`	`3372`	`/*`
`3364`	`3373`	`* Perform additional initialization and client authentication.`
`3365`	`3374`	`*`