Remove useless LIMIT_OPTION_DEFAULT value from LimitOption

alvherre · alvherre · commit a6be0600ac3b · 2023-12-16T18:20:03.000+01:00
During the development that led to commit 357889e, for a time we had the value LIMIT_OPTION_DEFAULT, which was mostly but not completely removed later on, before commit. Complete the removal now. Author: Zhang Mingli <avamingli@gmail.com> Discussion: https://postgr.es/m/59d61a1a-3858-475a-964f-24468c97cc67@Spark
diff --git a/src/backend/parser/gram.y b/src/backend/parser/gram.y
@@ -18461,7 +18461,7 @@ insertSelectOptions(SelectStmt *stmt,
 					 parser_errposition(exprLocation(limitClause->limitCount))));
 		stmt->limitCount = limitClause->limitCount;
 	}
-	if (limitClause && limitClause->limitOption != LIMIT_OPTION_DEFAULT)
+	if (limitClause)
 	{
 		if (stmt->limitOption)
 			ereport(ERROR,
diff --git a/src/include/nodes/nodes.h b/src/include/nodes/nodes.h
@@ -440,7 +440,6 @@ typedef enum LimitOption
 {
 	LIMIT_OPTION_COUNT,			/* FETCH FIRST... ONLY */
 	LIMIT_OPTION_WITH_TIES,		/* FETCH FIRST... WITH TIES */
-	LIMIT_OPTION_DEFAULT,		/* No limit present */
 } LimitOption;
 
 #endif							/* NODES_H */

Original file line number	Diff line number	Diff line change
`@@ -18461,7 +18461,7 @@ insertSelectOptions(SelectStmt *stmt,`
`18461`	`18461`	`parser_errposition(exprLocation(limitClause->limitCount))));`
`18462`	`18462`	`stmt->limitCount = limitClause->limitCount;`
`18463`	`18463`	`}`
`18464`		`- if (limitClause && limitClause->limitOption != LIMIT_OPTION_DEFAULT)`
	`18464`	`+ if (limitClause)`
`18465`	`18465`	`{`
`18466`	`18466`	`if (stmt->limitOption)`
`18467`	`18467`	`ereport(ERROR,`
Original file line number	Diff line number	Diff line change
`@@ -440,7 +440,6 @@ typedef enum LimitOption`
`440`	`440`	`{`
`441`	`441`	`LIMIT_OPTION_COUNT, /* FETCH FIRST... ONLY */`
`442`	`442`	`LIMIT_OPTION_WITH_TIES, /* FETCH FIRST... WITH TIES */`
`443`		`- LIMIT_OPTION_DEFAULT, /* No limit present */`
`444`	`443`	`} LimitOption;`
`445`	`444`
`446`	`445`	`#endif /* NODES_H */`