Fixes:

scrappy · scrappy · commit a7cfd6553227 · 1996-07-19T07:14:14.000Z
Select queries with an isnull or notnull clause, like "select * where
somefield isnull", crash the backend if the table has at least one index.
If the indices are deleted the queries work again. Also the explain
command fail in the same way.
The is caused by a bug in subroutine of the optimizer which doesn't check
null values in the clauses.

Submitted by: Massimo Dal Zotto &lt;dz@cs.unitn.it&gt;
diff --git a/src/backend/optimizer/path/indxpath.c b/src/backend/optimizer/path/indxpath.c
@@ -8,7 +8,7 @@
  *
  *
  * IDENTIFICATION
- *    $Header: /cvsroot/pgsql/src/backend/optimizer/path/indxpath.c,v 1.1.1.1 1996/07/09 06:21:35 scrappy Exp $
+ *    $Header: /cvsroot/pgsql/src/backend/optimizer/path/indxpath.c,v 1.2 1996/07/19 07:13:26 scrappy Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -493,7 +493,7 @@ match_clause_to_indexkey(Rel *rel,
 	    /*
 	     * Check for standard s-argable clause
 	     */
-	    if (IsA(rightop,Const))
+	    if (rightop && IsA(rightop,Const))
 		{
 		    restrict_op = ((Oper*)((Expr*)clause)->oper)->opno;
 		    isIndexable =
@@ -507,7 +507,7 @@ match_clause_to_indexkey(Rel *rel,
 	    /*
 	     * Must try to commute the clause to standard s-arg format.
 	     */
-	    else if (IsA(leftop,Const))
+	    else if (leftop && IsA(leftop,Const))
 		{
 		    restrict_op =
 			get_commutator(((Oper*)((Expr*)clause)->oper)->opno);
@@ -535,12 +535,14 @@ match_clause_to_indexkey(Rel *rel,
      */
     else
 	{
-	    if (match_index_to_operand(indexkey,(Expr*)rightop,rel,index)) {
+	    if (rightop
+		&& match_index_to_operand(indexkey,(Expr*)rightop,rel,index)) {
 					
 		join_op = get_commutator(((Oper*)((Expr*)clause)->oper)->opno);
 
-	    } else if (match_index_to_operand(indexkey,
-					      (Expr*)leftop,rel,index)) {
+	    } else if (leftop
+		       && match_index_to_operand(indexkey,
+						 (Expr*)leftop,rel,index)) {
 		join_op = ((Oper*)((Expr*)clause)->oper)->opno;
 	    }
 
diff --git a/src/backend/utils/adt/varlena.c b/src/backend/utils/adt/varlena.c
@@ -7,7 +7,7 @@
  *
  *
  * IDENTIFICATION
- *    $Header: /cvsroot/pgsql/src/backend/utils/adt/varlena.c,v 1.2 1996/07/19 06:08:21 scrappy Exp $
+ *    $Header: /cvsroot/pgsql/src/backend/utils/adt/varlena.c,v 1.3 1996/07/19 07:14:14 scrappy Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -198,8 +198,6 @@ textout(struct varlena *vlena)
 
 /* ========== PUBLIC ROUTINES ========== */
 
-/* 
-
 /*
  * textlen -
  *    returns the actual length of a text* (which may be less than

Original file line number	Diff line number	Diff line change
`@@ -8,7 +8,7 @@`
`8`	`8`	`*`
`9`	`9`	`*`
`10`	`10`	`* IDENTIFICATION`
`11`		`- * $Header: /cvsroot/pgsql/src/backend/optimizer/path/indxpath.c,v 1.1.1.1 1996/07/09 06:21:35 scrappy Exp $`
	`11`	`+ * $Header: /cvsroot/pgsql/src/backend/optimizer/path/indxpath.c,v 1.2 1996/07/19 07:13:26 scrappy Exp $`
`12`	`12`	`*`
`13`	`13`	`*-------------------------------------------------------------------------`
`14`	`14`	`*/`
`@@ -493,7 +493,7 @@ match_clause_to_indexkey(Rel *rel,`
`493`	`493`	`/*`
`494`	`494`	`* Check for standard s-argable clause`
`495`	`495`	`*/`
`496`		`- if (IsA(rightop,Const))`
	`496`	`+ if (rightop && IsA(rightop,Const))`
`497`	`497`	`{`
`498`	`498`	`restrict_op = ((Oper)((Expr)clause)->oper)->opno;`
`499`	`499`	`isIndexable =`
`@@ -507,7 +507,7 @@ match_clause_to_indexkey(Rel *rel,`
`507`	`507`	`/*`
`508`	`508`	`* Must try to commute the clause to standard s-arg format.`
`509`	`509`	`*/`
`510`		`- else if (IsA(leftop,Const))`
	`510`	`+ else if (leftop && IsA(leftop,Const))`
`511`	`511`	`{`
`512`	`512`	`restrict_op =`
`513`	`513`	`get_commutator(((Oper)((Expr)clause)->oper)->opno);`
`@@ -535,12 +535,14 @@ match_clause_to_indexkey(Rel *rel,`
`535`	`535`	`*/`
`536`	`536`	`else`
`537`	`537`	`{`
`538`		`- if (match_index_to_operand(indexkey,(Expr*)rightop,rel,index)) {`
	`538`	`+ if (rightop`
	`539`	`+ && match_index_to_operand(indexkey,(Expr*)rightop,rel,index)) {`
`539`	`540`
`540`	`541`	`join_op = get_commutator(((Oper)((Expr)clause)->oper)->opno);`
`541`	`542`
`542`		`- } else if (match_index_to_operand(indexkey,`
`543`		`- (Expr*)leftop,rel,index)) {`
	`543`	`+ } else if (leftop`
	`544`	`+ && match_index_to_operand(indexkey,`
	`545`	`+ (Expr*)leftop,rel,index)) {`
`544`	`546`	`join_op = ((Oper)((Expr)clause)->oper)->opno;`
`545`	`547`	`}`
`546`	`548`
Original file line number	Diff line number	Diff line change
`@@ -7,7 +7,7 @@`
`7`	`7`	`*`
`8`	`8`	`*`
`9`	`9`	`* IDENTIFICATION`
`10`		`- * $Header: /cvsroot/pgsql/src/backend/utils/adt/varlena.c,v 1.2 1996/07/19 06:08:21 scrappy Exp $`
	`10`	`+ * $Header: /cvsroot/pgsql/src/backend/utils/adt/varlena.c,v 1.3 1996/07/19 07:14:14 scrappy Exp $`
`11`	`11`	`*`
`12`	`12`	`*-------------------------------------------------------------------------`
`13`	`13`	`*/`
`@@ -198,8 +198,6 @@ textout(struct varlena *vlena)`
`198`	`198`
`199`	`199`	`/* ========== PUBLIC ROUTINES ========== */`
`200`	`200`
`201`		`-/*`
`202`		`-`
`203`	`201`	`/*`
`204`	`202`	`* textlen -`
`205`	`203`	`* returns the actual length of a text* (which may be less than`