Register llvm_shutdown using on_proc_exit, not before_shmem_exit.

robertmhaas · robertmhaas · commit bab150045bd9 · 2020-08-06T14:13:03.000-04:00
This seems more correct, because other before_shmem_exit calls may expect the infrastructure that is needed to run queries and access the database to be working, and also because this cleanup has nothing to do with shared memory. There are no known user-visible consequences to this, though, apart from what was previous fixed by commit 3036401 and back-patched as commit bcbc272 and commit f701368, so for now, no back-patch. Bharath Rupireddy Discussion: http://postgr.es/m/CALj2ACWk7j4F2v2fxxYfrroOF=AdFNPr1WsV+AGtHAFQOqm_pw@mail.gmail.com
diff --git a/src/backend/jit/llvm/llvmjit.c b/src/backend/jit/llvm/llvmjit.c
@@ -683,7 +683,7 @@ llvm_session_initialize(void)
 	}
 #endif
 
-	before_shmem_exit(llvm_shutdown, 0);
+	on_proc_exit(llvm_shutdown, 0);
 
 	llvm_session_initialized = true;
 

Original file line number	Diff line number	Diff line change
`@@ -683,7 +683,7 @@ llvm_session_initialize(void)`
`683`	`683`	`}`
`684`	`684`	`#endif`
`685`	`685`
`686`		`- before_shmem_exit(llvm_shutdown, 0);`
	`686`	`+ on_proc_exit(llvm_shutdown, 0);`
`687`	`687`
`688`	`688`	`llvm_session_initialized = true;`
`689`	`689`