Improve comment for OAT_POST_CREATE.

jeff-davis · jeff-davis · commit bb44a6ba48ed · 2022-09-20T10:52:01.000-07:00
Clarify that the command counter may or may not have been incremented. We may want to change the behavior to be more consistent, but until that time, at least improve the comment. Discussion: https://postgr.es/m/CAHoZxqvN2eoic_CvjsAvpryyLyA2xG8JmsyMtKFFJz_1oFhfOg%40mail.gmail.com Reported-by: Mary Xu
diff --git a/src/include/catalog/objectaccess.h b/src/include/catalog/objectaccess.h
@@ -17,7 +17,9 @@
  *
  * OAT_POST_CREATE should be invoked just after the object is created.
  * Typically, this is done after inserting the primary catalog records and
- * associated dependencies.
+ * associated dependencies. The command counter may or may not be incremented
+ * at the time the hook is invoked; if not, the extension can use SnapshotSelf
+ * to get the new version of the tuple.
  *
  * OAT_DROP should be invoked just before deletion of objects; typically
  * deleteOneObject(). Its arguments are packed within ObjectAccessDrop.

Original file line number	Diff line number	Diff line change
`@@ -17,7 +17,9 @@`
`17`	`17`	`*`
`18`	`18`	`* OAT_POST_CREATE should be invoked just after the object is created.`
`19`	`19`	`* Typically, this is done after inserting the primary catalog records and`
`20`		`- * associated dependencies.`
	`20`	`+ * associated dependencies. The command counter may or may not be incremented`
	`21`	`+ * at the time the hook is invoked; if not, the extension can use SnapshotSelf`
	`22`	`+ * to get the new version of the tuple.`
`21`	`23`	`*`
`22`	`24`	`* OAT_DROP should be invoked just before deletion of objects; typically`
`23`	`25`	`* deleteOneObject(). Its arguments are packed within ObjectAccessDrop.`