Fix an omission in the outfuncs.c support for Agg nodes: the grpColIdx

Neil Conway · Neil Conway · commit bbee1c5da81f · 2008-01-09T08:46:44.000Z
and grpOperators fields were not emitted by _outAgg().
diff --git a/src/backend/nodes/outfuncs.c b/src/backend/nodes/outfuncs.c
@@ -8,7 +8,7 @@
  *
  *
  * IDENTIFICATION
- *	  $PostgreSQL: pgsql/src/backend/nodes/outfuncs.c,v 1.321 2008/01/07 21:33:10 neilc Exp $
+ *	  $PostgreSQL: pgsql/src/backend/nodes/outfuncs.c,v 1.322 2008/01/09 08:46:44 neilc Exp $
  *
  * NOTES
  *	  Every node type that can appear in stored rules' parsetrees *must*
@@ -501,12 +501,23 @@ _outHashJoin(StringInfo str, HashJoin *node)
 static void
 _outAgg(StringInfo str, Agg *node)
 {
+	int i;
+
 	WRITE_NODE_TYPE("AGG");
 
 	_outPlanInfo(str, (Plan *) node);
 
 	WRITE_ENUM_FIELD(aggstrategy, AggStrategy);
 	WRITE_INT_FIELD(numCols);
+
+	appendStringInfo(str, " :grpColIdx");
+	for (i = 0; i < node->numCols; i++)
+		appendStringInfo(str, " %d", node->grpColIdx[i]);
+
+	appendStringInfo(str, " :grpOperators");
+	for (i = 0; i < node->numCols; i++)
+		appendStringInfo(str, " %u", node->grpOperators[i]);
+
 	WRITE_LONG_FIELD(numGroups);
 }
 

Original file line number	Diff line number	Diff line change
`@@ -8,7 +8,7 @@`
`8`	`8`	`*`
`9`	`9`	`*`
`10`	`10`	`* IDENTIFICATION`
`11`		`- * $PostgreSQL: pgsql/src/backend/nodes/outfuncs.c,v 1.321 2008/01/07 21:33:10 neilc Exp $`
	`11`	`+ * $PostgreSQL: pgsql/src/backend/nodes/outfuncs.c,v 1.322 2008/01/09 08:46:44 neilc Exp $`
`12`	`12`	`*`
`13`	`13`	`* NOTES`
`14`	`14`	`* Every node type that can appear in stored rules' parsetrees must`
`@@ -501,12 +501,23 @@ _outHashJoin(StringInfo str, HashJoin *node)`
`501`	`501`	`static void`
`502`	`502`	`_outAgg(StringInfo str, Agg *node)`
`503`	`503`	`{`
	`504`	`+ int i;`
	`505`	`+`
`504`	`506`	`WRITE_NODE_TYPE("AGG");`
`505`	`507`
`506`	`508`	`_outPlanInfo(str, (Plan *) node);`
`507`	`509`
`508`	`510`	`WRITE_ENUM_FIELD(aggstrategy, AggStrategy);`
`509`	`511`	`WRITE_INT_FIELD(numCols);`
	`512`	`+`
	`513`	`+ appendStringInfo(str, " :grpColIdx");`
	`514`	`+ for (i = 0; i < node->numCols; i++)`
	`515`	`+ appendStringInfo(str, " %d", node->grpColIdx[i]);`
	`516`	`+`
	`517`	`+ appendStringInfo(str, " :grpOperators");`
	`518`	`+ for (i = 0; i < node->numCols; i++)`
	`519`	`+ appendStringInfo(str, " %u", node->grpOperators[i]);`
	`520`	`+`
`510`	`521`	`WRITE_LONG_FIELD(numGroups);`
`511`	`522`	`}`
`512`	`523`