pgbench: Avoid unnecessary measurement of connection delays.

MasaoFujii · MasaoFujii · commit bfd4567b8849 · 2021-08-30T21:35:24.000+09:00
Commit 547f04e changed pgbench so that it used the measurement result of connection delays in its benchmark report only when -C/--connect option is specified. But previously those delays were unnecessarily measured even when that option is not specified. Which was a waste of cycles. This commit improves pgbench so that it avoids such unnecessary measurement. Back-patch to v14 where commit 547f04e first appeared. Author: Yugo Nagata Reviewed-by: Fabien COELHO, Asif Rehman, Fujii Masao Discussion: https://postgr.es/m/20210614151155.a393bc7d8fed183e38c9f52a@sraoss.co.jp
diff --git a/src/bin/pgbench/pgbench.c b/src/bin/pgbench/pgbench.c
@@ -6603,6 +6603,7 @@ threadRun(void *arg)
 
 	thread_start = pg_time_now();
 	thread->started_time = thread_start;
+	thread->conn_duration = 0;
 	last_report = thread_start;
 	next_report = last_report + (int64) 1000000 * progress;
 
@@ -6626,14 +6627,6 @@ threadRun(void *arg)
 				goto done;
 			}
 		}
-
-		/* compute connection delay */
-		thread->conn_duration = pg_time_now() - thread->started_time;
-	}
-	else
-	{
-		/* no connection delay to record */
-		thread->conn_duration = 0;
 	}
 
 	/* GO */

Original file line number	Diff line number	Diff line change
`@@ -6603,6 +6603,7 @@ threadRun(void *arg)`
`6603`	`6603`
`6604`	`6604`	`thread_start = pg_time_now();`
`6605`	`6605`	`thread->started_time = thread_start;`
	`6606`	`+ thread->conn_duration = 0;`
`6606`	`6607`	`last_report = thread_start;`
`6607`	`6608`	`next_report = last_report + (int64) 1000000 * progress;`
`6608`	`6609`
`@@ -6626,14 +6627,6 @@ threadRun(void *arg)`
`6626`	`6627`	`goto done;`
`6627`	`6628`	`}`
`6628`	`6629`	`}`
`6629`		`-`
`6630`		`- /* compute connection delay */`
`6631`		`- thread->conn_duration = pg_time_now() - thread->started_time;`
`6632`		`- }`
`6633`		`- else`
`6634`		`- {`
`6635`		`- /* no connection delay to record */`
`6636`		`- thread->conn_duration = 0;`
`6637`	`6630`	`}`
`6638`	`6631`
`6639`	`6632`	`/* GO */`