This trivial patch fixes a small memory leak in pg_dump.

bmomjian · bmomjian · commit ce5bb92346af · 2002-08-04T05:03:29.000Z
Neil Conway
diff --git a/src/bin/pg_dump/pg_dump.c b/src/bin/pg_dump/pg_dump.c
@@ -22,7 +22,7 @@
  *
  *
  * IDENTIFICATION
- *	  $Header: /cvsroot/pgsql/src/bin/pg_dump/pg_dump.c,v 1.279 2002/08/02 18:15:08 tgl Exp $
+ *	  $Header: /cvsroot/pgsql/src/bin/pg_dump/pg_dump.c,v 1.280 2002/08/04 05:03:29 momjian Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -5378,6 +5378,8 @@ dumpIndexes(Archive *fout, TableInfo *tblinfo, int numTables)
 							 q->data, "",
 							 NULL, NULL, NULL);
 
+				for (k = 0; k < indnkeys; k++)
+					free(indkeys[k]);
 				free(indkeys);
 			}
 			else

Original file line number	Diff line number	Diff line change
`@@ -22,7 +22,7 @@`
`22`	`22`	`*`
`23`	`23`	`*`
`24`	`24`	`* IDENTIFICATION`
`25`		`- * $Header: /cvsroot/pgsql/src/bin/pg_dump/pg_dump.c,v 1.279 2002/08/02 18:15:08 tgl Exp $`
	`25`	`+ * $Header: /cvsroot/pgsql/src/bin/pg_dump/pg_dump.c,v 1.280 2002/08/04 05:03:29 momjian Exp $`
`26`	`26`	`*`
`27`	`27`	`*-------------------------------------------------------------------------`
`28`	`28`	`*/`
`@@ -5378,6 +5378,8 @@ dumpIndexes(Archive fout, TableInfo tblinfo, int numTables)`
`5378`	`5378`	`q->data, "",`
`5379`	`5379`	`NULL, NULL, NULL);`
`5380`	`5380`
	`5381`	`+ for (k = 0; k < indnkeys; k++)`
	`5382`	`+ free(indkeys[k]);`
`5381`	`5383`	`free(indkeys);`
`5382`	`5384`	`}`
`5383`	`5385`	`else`