pageinspect: Make page deletion elog less chatty.

petergeoghegan · petergeoghegan · commit d7897abf9e00 · 2021-09-17T14:19:51.000-07:00
An elog that reports the value of a transaction ID stored on a deleted nbtree page was added by commit e5d8a99, which taught page deletion to store full 64-bit XIDs. It seems very chatty on further reflection, so lower its elevel from NOTICE to DEBUG2. Author: Peter Geoghegan <pg@bowt.ie> Backpatch: 14-, just like the nbtree XID enhancement.
diff --git a/contrib/pageinspect/btreefuncs.c b/contrib/pageinspect/btreefuncs.c
@@ -125,12 +125,12 @@ GetBTPageStatistics(BlockNumber blkno, Buffer buffer, BTPageStat *stat)
 		{
 			FullTransactionId safexid = BTPageGetDeleteXid(page);
 
-			elog(NOTICE, "deleted page from block %u has safexid %u:%u",
+			elog(DEBUG2, "deleted page from block %u has safexid %u:%u",
 				 blkno, EpochFromFullTransactionId(safexid),
 				 XidFromFullTransactionId(safexid));
 		}
 		else
-			elog(NOTICE, "deleted page from block %u has safexid %u",
+			elog(DEBUG2, "deleted page from block %u has safexid %u",
 				 blkno, opaque->btpo_level);
 
 		/* Don't interpret BTDeletedPageData as index tuples */

Original file line number	Diff line number	Diff line change
`@@ -125,12 +125,12 @@ GetBTPageStatistics(BlockNumber blkno, Buffer buffer, BTPageStat *stat)`
`125`	`125`	`{`
`126`	`126`	`FullTransactionId safexid = BTPageGetDeleteXid(page);`
`127`	`127`
`128`		`- elog(NOTICE, "deleted page from block %u has safexid %u:%u",`
	`128`	`+ elog(DEBUG2, "deleted page from block %u has safexid %u:%u",`
`129`	`129`	`blkno, EpochFromFullTransactionId(safexid),`
`130`	`130`	`XidFromFullTransactionId(safexid));`
`131`	`131`	`}`
`132`	`132`	`else`
`133`		`- elog(NOTICE, "deleted page from block %u has safexid %u",`
	`133`	`+ elog(DEBUG2, "deleted page from block %u has safexid %u",`
`134`	`134`	`blkno, opaque->btpo_level);`
`135`	`135`
`136`	`136`	`/* Don't interpret BTDeletedPageData as index tuples */`