pg_upgrade: Tweak translatable strings

petere · petere · commit da1c0acd0a61 · 2022-05-23T10:54:39.000+02:00
"\r" (for progress output) must not be inside a translatable string
(gettext gets upset).

In passing, move the minimum supported version number to a separate
argument, so that we don't have to retranslate this string every year
now.
diff --git a/src/bin/pg_upgrade/check.c b/src/bin/pg_upgrade/check.c
@@ -289,7 +289,8 @@ check_cluster_versions(void)
 	 */
 
 	if (GET_MAJOR_VERSION(old_cluster.major_version) < 902)
-		pg_fatal("This utility can only upgrade from PostgreSQL version 9.2 and later.\n");
+		pg_fatal("This utility can only upgrade from PostgreSQL version %s and later.\n",
+				 "9.2");
 
 	/* Only current PG version is supported as a target */
 	if (GET_MAJOR_VERSION(new_cluster.major_version) != GET_MAJOR_VERSION(PG_VERSION_NUM))
diff --git a/src/bin/pg_upgrade/util.c b/src/bin/pg_upgrade/util.c
@@ -47,7 +47,10 @@ end_progress_output(void)
 	 * nicely.
 	 */
 	if (log_opts.isatty)
-		pg_log(PG_REPORT, "\r%-*s", MESSAGE_WIDTH, "");
+	{
+		printf("\r");
+		pg_log(PG_REPORT, "%-*s", MESSAGE_WIDTH, "");
+	}
 	else if (log_opts.verbose)
 		pg_log(PG_REPORT, "%-*s", MESSAGE_WIDTH, "");
 }
