Improve a couple of error messages per suggestions from Alvaro Herrera.

tglsfdc · tglsfdc · commit daed6f4b945c · 2003-09-15T22:28:58.000Z
diff --git a/src/backend/parser/gram.y b/src/backend/parser/gram.y
@@ -11,7 +11,7 @@
  *
  *
  * IDENTIFICATION
- *	  $Header: /cvsroot/pgsql/src/backend/parser/gram.y,v 2.432 2003/09/09 23:22:20 petere Exp $
+ *	  $Header: /cvsroot/pgsql/src/backend/parser/gram.y,v 2.433 2003/09/15 22:28:57 tgl Exp $
  *
  * HISTORY
  *	  AUTHOR			DATE			MAJOR EVENT
@@ -3244,7 +3244,8 @@ oper_argtypes:
 				{
 				   ereport(ERROR,
 						   (errcode(ERRCODE_SYNTAX_ERROR),
-							errmsg("argument type missing (use NONE for unary operators)")));
+							errmsg("missing argument"),
+							errhint("Use NONE to denote the missing argument of a unary operator.")));
 				}
 			| Typename ',' Typename
 					{ $$ = makeList2($1, $3); }
diff --git a/src/backend/utils/misc/guc.c b/src/backend/utils/misc/guc.c
@@ -10,7 +10,7 @@
  * Written by Peter Eisentraut <peter_e@gmx.net>.
  *
  * IDENTIFICATION
- *	  $Header: /cvsroot/pgsql/src/backend/utils/misc/guc.c,v 1.157 2003/09/11 18:30:39 momjian Exp $
+ *	  $Header: /cvsroot/pgsql/src/backend/utils/misc/guc.c,v 1.158 2003/09/15 22:28:58 tgl Exp $
  *
  *--------------------------------------------------------------------
  */
@@ -1540,7 +1540,7 @@ static struct config_string ConfigureNamesString[] =
 
 	{
 		{"unix_socket_group", PGC_POSTMASTER, CONN_AUTH_SETTINGS,
-			gettext_noop("The group owner of the Unix domain socket"),
+			gettext_noop("The owning group of the Unix-domain socket"),
 			gettext_noop("(The owning user of the socket is always the user "
 						 "that starts the server.)")
 		},
@@ -1550,7 +1550,7 @@ static struct config_string ConfigureNamesString[] =
 
 	{
 		{"unix_socket_directory", PGC_POSTMASTER, CONN_AUTH_SETTINGS,
-			gettext_noop("The Unix-domain socket directory to listen to"),
+			gettext_noop("Directory where the Unix-domain socket will be created"),
 			NULL
 		},
 		&UnixSocketDir,

Original file line number	Diff line number	Diff line change
`@@ -11,7 +11,7 @@`
`11`	`11`	`*`
`12`	`12`	`*`
`13`	`13`	`* IDENTIFICATION`
`14`		`- * $Header: /cvsroot/pgsql/src/backend/parser/gram.y,v 2.432 2003/09/09 23:22:20 petere Exp $`
	`14`	`+ * $Header: /cvsroot/pgsql/src/backend/parser/gram.y,v 2.433 2003/09/15 22:28:57 tgl Exp $`
`15`	`15`	`*`
`16`	`16`	`* HISTORY`
`17`	`17`	`* AUTHOR DATE MAJOR EVENT`
`@@ -3244,7 +3244,8 @@ oper_argtypes:`
`3244`	`3244`	`{`
`3245`	`3245`	`ereport(ERROR,`
`3246`	`3246`	`(errcode(ERRCODE_SYNTAX_ERROR),`
`3247`		`- errmsg("argument type missing (use NONE for unary operators)")));`
	`3247`	`+ errmsg("missing argument"),`
	`3248`	`+ errhint("Use NONE to denote the missing argument of a unary operator.")));`
`3248`	`3249`	`}`
`3249`	`3250`	`\| Typename ',' Typename`
`3250`	`3251`	`{ $$ = makeList2($1, $3); }`
Original file line number	Diff line number	Diff line change
`@@ -10,7 +10,7 @@`
`10`	`10`	`* Written by Peter Eisentraut <peter_e@gmx.net>.`
`11`	`11`	`*`
`12`	`12`	`* IDENTIFICATION`
`13`		`- * $Header: /cvsroot/pgsql/src/backend/utils/misc/guc.c,v 1.157 2003/09/11 18:30:39 momjian Exp $`
	`13`	`+ * $Header: /cvsroot/pgsql/src/backend/utils/misc/guc.c,v 1.158 2003/09/15 22:28:58 tgl Exp $`
`14`	`14`	`*`
`15`	`15`	`*--------------------------------------------------------------------`
`16`	`16`	`*/`
`@@ -1540,7 +1540,7 @@ static struct config_string ConfigureNamesString[] =`
`1540`	`1540`
`1541`	`1541`	`{`
`1542`	`1542`	`{"unix_socket_group", PGC_POSTMASTER, CONN_AUTH_SETTINGS,`
`1543`		`- gettext_noop("The group owner of the Unix domain socket"),`
	`1543`	`+ gettext_noop("The owning group of the Unix-domain socket"),`
`1544`	`1544`	`gettext_noop("(The owning user of the socket is always the user "`
`1545`	`1545`	`"that starts the server.)")`
`1546`	`1546`	`},`
`@@ -1550,7 +1550,7 @@ static struct config_string ConfigureNamesString[] =`
`1550`	`1550`
`1551`	`1551`	`{`
`1552`	`1552`	`{"unix_socket_directory", PGC_POSTMASTER, CONN_AUTH_SETTINGS,`
`1553`		`- gettext_noop("The Unix-domain socket directory to listen to"),`
	`1553`	`+ gettext_noop("Directory where the Unix-domain socket will be created"),`
`1554`	`1554`	`NULL`
`1555`	`1555`	`},`
`1556`	`1556`	`&UnixSocketDir,`