Remove redundant assignments in copyfrom.c

michaelpq · michaelpq · commit e434e21e114b · 2023-09-09T21:12:41.000+09:00
The tuple descriptor and the number of attributes are assigned twice to the same values in BeginCopyFrom(), for what looks like a small thinko coming from the refactoring done in c532d15. Author: Jingtang Zhang Discussion: https://postgr.es/m/CAPsk3_CrYeXUVHEiaWAYxY9BKiGvGT3AoXo_+Jm0xP_s_VmXCA@mail.gmail.com
diff --git a/src/backend/commands/copyfrom.c b/src/backend/commands/copyfrom.c
@@ -1533,8 +1533,6 @@ BeginCopyFrom(ParseState *pstate,
 		cstate->rteperminfos = pstate->p_rteperminfos;
 	}
 
-	tupDesc = RelationGetDescr(cstate->rel);
-	num_phys_attrs = tupDesc->natts;
 	num_defaults = 0;
 	volatile_defexprs = false;
 

Original file line number	Diff line number	Diff line change
`@@ -1533,8 +1533,6 @@ BeginCopyFrom(ParseState *pstate,`
`1533`	`1533`	`cstate->rteperminfos = pstate->p_rteperminfos;`
`1534`	`1534`	`}`
`1535`	`1535`
`1536`		`- tupDesc = RelationGetDescr(cstate->rel);`
`1537`		`- num_phys_attrs = tupDesc->natts;`
`1538`	`1536`	`num_defaults = 0;`
`1539`	`1537`	`volatile_defexprs = false;`
`1540`	`1538`