A few follow-up fixes for GUC name quoting

petere · petere · commit e9b7aee27283 · 2024-05-17T13:48:31.000+02:00
Fixups for 17974ec: Some messages were missed (and some were new since the patch was originally proposed), and there was a typo introduced.
diff --git a/src/backend/libpq/be-secure-openssl.c b/src/backend/libpq/be-secure-openssl.c
@@ -224,7 +224,7 @@ be_tls_init(bool isServerStart)
 		{
 			ereport(isServerStart ? FATAL : LOG,
 			/*- translator: first %s is a GUC option name, second %s is its value */
-					(errmsg("%s setting \"%s\" not supported by this build",
+					(errmsg("\"%s\" setting \"%s\" not supported by this build",
 							"ssl_max_protocol_version",
 							GetConfigOption("ssl_max_protocol_version",
 											false, false))));
diff --git a/src/backend/postmaster/bgworker.c b/src/backend/postmaster/bgworker.c
@@ -928,7 +928,7 @@ RegisterBackgroundWorker(BackgroundWorker *worker)
 								  "Up to %d background workers can be registered with the current settings.",
 								  max_worker_processes,
 								  max_worker_processes),
-				 errhint("Consider increasing the configuration parameter max_worker_processes.")));
+				 errhint("Consider increasing the configuration parameter \"max_worker_processes\".")));
 		return;
 	}
 
diff --git a/src/backend/postmaster/pgarch.c b/src/backend/postmaster/pgarch.c
@@ -895,7 +895,7 @@ HandlePgArchInterrupts(void)
 			 */
 			ereport(LOG,
 					(errmsg("restarting archiver process because value of "
-							"archive_library was changed")));
+							"\"archive_library\" was changed")));
 
 			proc_exit(0);
 		}
diff --git a/src/backend/replication/logical/slotsync.c b/src/backend/replication/logical/slotsync.c
@@ -1047,7 +1047,7 @@ ValidateSlotSyncParams(int elevel)
 	if (wal_level < WAL_LEVEL_LOGICAL)
 		ereport(ERROR,
 				errcode(ERRCODE_INVALID_PARAMETER_VALUE),
-				errmsg("slot synchronization requires wal_level >= \"logical\""));
+				errmsg("slot synchronization requires \"wal_level\" >= \"logical\""));
 
 	/*
 	 * A physical replication slot(primary_slot_name) is required on the
diff --git a/src/backend/utils/misc/guc_tables.c b/src/backend/utils/misc/guc_tables.c
@@ -1114,7 +1114,7 @@ struct config_bool ConfigureNamesBool[] =
 			gettext_noop("Continues processing past damaged page headers."),
 			gettext_noop("Detection of a damaged page header normally causes PostgreSQL to "
 						 "report an error, aborting the current transaction. Setting "
-						 "\"zero_damaged_page\" to true causes the system to instead report a "
+						 "\"zero_damaged_pages\" to true causes the system to instead report a "
 						 "warning, zero out the damaged page, and continue processing. This "
 						 "behavior will destroy data, namely all the rows on the damaged page."),
 			GUC_NOT_IN_SAMPLE

Original file line number	Diff line number	Diff line change
`@@ -224,7 +224,7 @@ be_tls_init(bool isServerStart)`
`224`	`224`	`{`
`225`	`225`	`ereport(isServerStart ? FATAL : LOG,`
`226`	`226`	`/- translator: first %s is a GUC option name, second %s is its value /`
`227`		`- (errmsg("%s setting \"%s\" not supported by this build",`
	`227`	`+ (errmsg("\"%s\" setting \"%s\" not supported by this build",`
`228`	`228`	`"ssl_max_protocol_version",`
`229`	`229`	`GetConfigOption("ssl_max_protocol_version",`
`230`	`230`	`false, false))));`
Original file line number	Diff line number	Diff line change
`@@ -928,7 +928,7 @@ RegisterBackgroundWorker(BackgroundWorker *worker)`
`928`	`928`	`"Up to %d background workers can be registered with the current settings.",`
`929`	`929`	`max_worker_processes,`
`930`	`930`	`max_worker_processes),`
`931`		`- errhint("Consider increasing the configuration parameter max_worker_processes.")));`
	`931`	`+ errhint("Consider increasing the configuration parameter \"max_worker_processes\".")));`
`932`	`932`	`return;`
`933`	`933`	`}`
`934`	`934`
Original file line number	Diff line number	Diff line change
`@@ -895,7 +895,7 @@ HandlePgArchInterrupts(void)`
`895`	`895`	`*/`
`896`	`896`	`ereport(LOG,`
`897`	`897`	`(errmsg("restarting archiver process because value of "`
`898`		`- "archive_library was changed")));`
	`898`	`+ "\"archive_library\" was changed")));`
`899`	`899`
`900`	`900`	`proc_exit(0);`
`901`	`901`	`}`