pgbench: If we fail to send a command to the server, fail.

robertmhaas · robertmhaas · commit 434146d21666 · 2017-09-29T13:56:04.000-04:00
This beats the old behavior of busy-waiting hands down. Oversight in commit 12788ae. Report by Pavan Deolasee. Patch by Fabien Coelho. Reviewed by Pavan Deolasee. Discussion: http://postgr.es/m/CABOikdPhfXTypckMC1Ux6Ko+hKBWwUBA=EXsvamXYSg8M9J94w@mail.gmail.com
diff --git a/src/bin/pgbench/pgbench.c b/src/bin/pgbench/pgbench.c
@@ -2157,12 +2157,8 @@ doCustom(TState *thread, CState *st, StatsData *agg)
 				{
 					if (!sendCommand(st, command))
 					{
-						/*
-						 * Failed. Stay in CSTATE_START_COMMAND state, to
-						 * retry. ??? What the point or retrying? Should
-						 * rather abort?
-						 */
-						return;
+						commandFailed(st, "SQL command send failed");
+						st->state = CSTATE_ABORTED;
 					}
 					else
 						st->state = CSTATE_WAIT_RESULT;

Original file line number	Diff line number	Diff line change
`@@ -2157,12 +2157,8 @@ doCustom(TState thread, CState st, StatsData *agg)`
`2157`	`2157`	`{`
`2158`	`2158`	`if (!sendCommand(st, command))`
`2159`	`2159`	`{`
`2160`		`- /*`
`2161`		`- * Failed. Stay in CSTATE_START_COMMAND state, to`
`2162`		`- * retry. ??? What the point or retrying? Should`
`2163`		`- * rather abort?`
`2164`		`- */`
`2165`		`- return;`
	`2160`	`+ commandFailed(st, "SQL command send failed");`
	`2161`	`+ st->state = CSTATE_ABORTED;`
`2166`	`2162`	`}`
`2167`	`2163`	`else`
`2168`	`2164`	`st->state = CSTATE_WAIT_RESULT;`