Make directory name comparisons on Win32 case insensitive.

mhagander · mhagander · commit aa38153d22df · 2009-04-03T11:52:08.000Z
This method will not catch all different ways since the locale
handling in NTFS doesn't provide an easy way to do that, but it
will hopefully solve the most common cases causing startup
problems when the backend is found in the system PATH.

Attempts to fix bug #4694.
diff --git a/src/port/path.c b/src/port/path.c
@@ -8,7 +8,7 @@
  *
  *
  * IDENTIFICATION
- *	  $PostgreSQL: pgsql/src/port/path.c,v 1.76 2009/01/01 17:24:04 momjian Exp $
+ *	  $PostgreSQL: pgsql/src/port/path.c,v 1.77 2009/04/03 11:52:08 mha Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -427,7 +427,12 @@ dir_strcmp(const char *s1, const char *s2)
 {
 	while (*s1 && *s2)
 	{
+#ifndef WIN32
 		if (*s1 != *s2 &&
+#else
+			/* On windows, paths are case-insensitive */
+		if (pg_tolower(*s1) != pg_tolower(*s2) &&
+#endif
 			!(IS_DIR_SEP(*s1) && IS_DIR_SEP(*s2)))
 			return (int) *s1 - (int) *s2;
 		s1++, s2++;

Original file line number	Diff line number	Diff line change
`@@ -8,7 +8,7 @@`
`8`	`8`	`*`
`9`	`9`	`*`
`10`	`10`	`* IDENTIFICATION`
`11`		`- * $PostgreSQL: pgsql/src/port/path.c,v 1.76 2009/01/01 17:24:04 momjian Exp $`
	`11`	`+ * $PostgreSQL: pgsql/src/port/path.c,v 1.77 2009/04/03 11:52:08 mha Exp $`
`12`	`12`	`*`
`13`	`13`	`*-------------------------------------------------------------------------`
`14`	`14`	`*/`
`@@ -427,7 +427,12 @@ dir_strcmp(const char s1, const char s2)`
`427`	`427`	`{`
`428`	`428`	`while (s1 && s2)`
`429`	`429`	`{`
	`430`	`+#ifndef WIN32`
`430`	`431`	`if (s1 != s2 &&`
	`432`	`+#else`
	`433`	`+ /* On windows, paths are case-insensitive */`
	`434`	`+ if (pg_tolower(s1) != pg_tolower(s2) &&`
	`435`	`+#endif`
`431`	`436`	`!(IS_DIR_SEP(s1) && IS_DIR_SEP(s2)))`
`432`	`437`	`return (int) s1 - (int) s2;`
`433`	`438`	`s1++, s2++;`