Fix small query-lifespan memory leak in bulk updates.

tglsfdc · tglsfdc · commit 46bd14a108ff · 2016-08-24T22:20:01.000-04:00
When there is an identifiable REPLICA IDENTITY index on the target table, heap_update leaks the id_attrs bitmapset. That's not many bytes, but it adds up over enough rows, since the code typically runs in a query-lifespan context. Bug introduced in commit e55704d, which did a rather poor job of cloning the existing use-pattern for RelationGetIndexAttrBitmap(). Per bug #14293 from Zhou Digoal. Back-patch to 9.4 where the bug was introduced. Report: <20160824114320.15676.45171@wrigleys.postgresql.org>
diff --git a/src/backend/access/heap/heapam.c b/src/backend/access/heap/heapam.c
@@ -3579,6 +3579,7 @@ heap_update(Relation relation, ItemPointer otid, HeapTuple newtup,
 			ReleaseBuffer(vmbuffer);
 		bms_free(hot_attrs);
 		bms_free(key_attrs);
+		bms_free(id_attrs);
 		return result;
 	}
 
@@ -4031,6 +4032,7 @@ heap_update(Relation relation, ItemPointer otid, HeapTuple newtup,
 
 	bms_free(hot_attrs);
 	bms_free(key_attrs);
+	bms_free(id_attrs);
 
 	return HeapTupleMayBeUpdated;
 }

Original file line number	Diff line number	Diff line change
`@@ -3579,6 +3579,7 @@ heap_update(Relation relation, ItemPointer otid, HeapTuple newtup,`
`3579`	`3579`	`ReleaseBuffer(vmbuffer);`
`3580`	`3580`	`bms_free(hot_attrs);`
`3581`	`3581`	`bms_free(key_attrs);`
	`3582`	`+ bms_free(id_attrs);`
`3582`	`3583`	`return result;`
`3583`	`3584`	`}`
`3584`	`3585`
`@@ -4031,6 +4032,7 @@ heap_update(Relation relation, ItemPointer otid, HeapTuple newtup,`
`4031`	`4032`
`4032`	`4033`	`bms_free(hot_attrs);`
`4033`	`4034`	`bms_free(key_attrs);`
	`4035`	`+ bms_free(id_attrs);`
`4034`	`4036`
`4035`	`4037`	`return HeapTupleMayBeUpdated;`
`4036`	`4038`	`}`