Error out on send failure in walsender loop.

hlinnaka · hlinnaka · commit 7558cc95d31e · 2014-03-04T15:36:05.000+02:00
I changed the loop in 9.3 to use "goto send_failure" instead of "break" on
errors, but I missed this one case. It was a relatively harmless bug: if
the flush fails once it will most likely fail again as soon as we try to
flush the output again. But it's a bug nevertheless.

Report and fix by Andres Freund.
diff --git a/src/backend/replication/walsender.c b/src/backend/replication/walsender.c
@@ -1291,7 +1291,7 @@ WalSndLoop(void)
 					ping_sent = true;
 					/* Try to flush pending output to the client */
 					if (pq_flush_if_writable() != 0)
-						break;
+						goto send_failure;
 				}
 			}
 

Original file line number	Diff line number	Diff line change
`@@ -1291,7 +1291,7 @@ WalSndLoop(void)`
`1291`	`1291`	`ping_sent = true;`
`1292`	`1292`	`/* Try to flush pending output to the client */`
`1293`	`1293`	`if (pq_flush_if_writable() != 0)`
`1294`		`- break;`
	`1294`	`+ goto send_failure;`
`1295`	`1295`	`}`
`1296`	`1296`	`}`
`1297`	`1297`