Fix bug in the new GIN incomplete-split code.

hlinnaka · hlinnaka · commit 8bbbcb91bae1 · 2014-04-01T22:49:47.000+03:00
Inserting a downlink to an internal page clears the incomplete-split flag
of the child's left sibling, so the left sibling's LSN also needs to be
updated and it needs to be marked dirty. The codepath for an insertion got
this right, but the case where the internal node is split because of
inserting the new downlink missed that.
diff --git a/src/backend/access/gin/ginbtree.c b/src/backend/access/gin/ginbtree.c
@@ -543,6 +543,8 @@ ginPlaceToPage(GinBtree btree, GinBtreeStack *stack,
 
 		MarkBufferDirty(rbuffer);
 		MarkBufferDirty(stack->buffer);
+		if (BufferIsValid(childbuf))
+			MarkBufferDirty(childbuf);
 
 		/*
 		 * Restore the temporary copies over the real buffers. But don't free
@@ -571,6 +573,8 @@ ginPlaceToPage(GinBtree btree, GinBtreeStack *stack,
 			PageSetLSN(BufferGetPage(rbuffer), recptr);
 			if (stack->parent == NULL)
 				PageSetLSN(BufferGetPage(lbuffer), recptr);
+			if (BufferIsValid(childbuf))
+				PageSetLSN(childpage, recptr);
 		}
 		END_CRIT_SECTION();
 
