Fix typo in ReorderBufferIterTXNInit().

tglsfdc · tglsfdc · commit 8caf9fe62544 · 2016-06-30T12:37:02.000-04:00
This looks like it would cause changes from subtransactions to be missed
by the iterator being constructed, if those changes had been spilled to
disk previously.  This implies that large subtransactions might be lost
(in whole or in part) by logical replication.  Found and fixed by
Petru-Florin Mihancea, per bug #14208.

Report: &lt;20160622144830.5791.22512@wrigleys.postgresql.org&gt;
diff --git a/src/backend/replication/logical/reorderbuffer.c b/src/backend/replication/logical/reorderbuffer.c
@@ -897,7 +897,7 @@ ReorderBufferIterTXNInit(ReorderBuffer *rb, ReorderBufferTXN *txn)
 		{
 			ReorderBufferChange *cur_change;
 
-			if (txn->nentries != txn->nentries_mem)
+			if (cur_txn->nentries != cur_txn->nentries_mem)
 				ReorderBufferRestoreChanges(rb, cur_txn,
 											&state->entries[off].fd,
 											&state->entries[off].segno);

Original file line number	Diff line number	Diff line change
`@@ -897,7 +897,7 @@ ReorderBufferIterTXNInit(ReorderBuffer rb, ReorderBufferTXN txn)`
`897`	`897`	`{`
`898`	`898`	`ReorderBufferChange *cur_change;`
`899`	`899`
`900`		`- if (txn->nentries != txn->nentries_mem)`
	`900`	`+ if (cur_txn->nentries != cur_txn->nentries_mem)`
`901`	`901`	`ReorderBufferRestoreChanges(rb, cur_txn,`
`902`	`902`	`&state->entries[off].fd,`
`903`	`903`	`&state->entries[off].segno);`