Fix pgbench's calculation of average latency, when -T is not used.

hlinnaka · hlinnaka · commit b93d37474fdf · 2016-09-21T13:16:20.000+03:00
If the test duration was given in # of transactions (-t or no option),
rather as a duration (-T), the latency average was always printed as 0.
It has been broken ever since the display of latency average was added,
in 9.4.

Fabien Coelho

Discussion: &lt;alpine.DEB.2.20.1607131015370.7486@sto&gt;
diff --git a/src/bin/pgbench/pgbench.c b/src/bin/pgbench/pgbench.c
@@ -2736,9 +2736,9 @@ printResults(int ttype, int64 normal_xacts, int nclients,
 	}
 	else
 	{
-		/* only an average latency computed from the duration is available */
+		/* no measurement, show average latency computed from run time */
 		printf("latency average: %.3f ms\n",
-			   1000.0 * duration * nclients / normal_xacts);
+			   1000.0 * time_include * nclients / normal_xacts);
 	}
 
 	if (throttle_delay)

Original file line number	Diff line number	Diff line change
`@@ -2736,9 +2736,9 @@ printResults(int ttype, int64 normal_xacts, int nclients,`
`2736`	`2736`	`}`
`2737`	`2737`	`else`
`2738`	`2738`	`{`
`2739`		`- /* only an average latency computed from the duration is available */`
	`2739`	`+ /* no measurement, show average latency computed from run time */`
`2740`	`2740`	`printf("latency average: %.3f ms\n",`
`2741`		`- 1000.0 * duration * nclients / normal_xacts);`
	`2741`	`+ 1000.0 * time_include * nclients / normal_xacts);`
`2742`	`2742`	`}`
`2743`	`2743`
`2744`	`2744`	`if (throttle_delay)`