Fix crash in CREATE UNLOGGED TABLE.

robertmhaas · robertmhaas · commit bf347c60bdd7 · 2011-06-17T13:34:39.000-04:00
The code that created the init fork neglected to make sure that the
relation was open at the smgr level before attempting to invoke smgr.
This didn't happen every time; only when the relcache entry was rebuilt
along the way.

Per report from Garick Hamlin.
diff --git a/src/backend/catalog/heap.c b/src/backend/catalog/heap.c
@@ -1295,6 +1295,7 @@ heap_create_with_catalog(const char *relname,
 	{
 		Assert(relkind == RELKIND_RELATION || relkind == RELKIND_TOASTVALUE);
 
+		RelationOpenSmgr(new_rel_desc);
 		smgrcreate(new_rel_desc->rd_smgr, INIT_FORKNUM, false);
 		if (XLogIsNeeded())
 			log_smgrcreate(&new_rel_desc->rd_smgr->smgr_rnode.node,

Original file line number	Diff line number	Diff line change
`@@ -1295,6 +1295,7 @@ heap_create_with_catalog(const char *relname,`
`1295`	`1295`	`{`
`1296`	`1296`	`Assert(relkind == RELKIND_RELATION \|\| relkind == RELKIND_TOASTVALUE);`
`1297`	`1297`
	`1298`	`+ RelationOpenSmgr(new_rel_desc);`
`1298`	`1299`	`smgrcreate(new_rel_desc->rd_smgr, INIT_FORKNUM, false);`
`1299`	`1300`	`if (XLogIsNeeded())`
`1300`	`1301`	`log_smgrcreate(&new_rel_desc->rd_smgr->smgr_rnode.node,`