Fix alignment of GIN in-line posting lists stored in entry tuples.

hlinnaka · hlinnaka · commit ec8f692c3cd5 · 2014-01-23T22:58:12.000+02:00
The Sparc machines in the buildfarm are crashing because of misaligned
access to posting lists stored in entry tuples.

I accidentally removed a critical SHORTALIGN() from ginFormTuple, as part
of the packed posting lists patch. Perhaps I thought it was unnecessary,
because the index_form_tuple() call above the SHORTALIGN already aligned
the size, missing the fact that the null-category byte makes it misaligned
again (I think the SHORTALIGN is indeed unnecessary if there's no null-
category byte, but let's just play it safe...)
diff --git a/src/backend/access/gin/ginentrypage.c b/src/backend/access/gin/ginentrypage.c
@@ -87,6 +87,8 @@ GinFormTuple(GinState *ginstate,
 		newsize = Max(newsize, minsize);
 	}
 
+	newsize = SHORTALIGN(newsize);
+
 	GinSetPostingOffset(itup, newsize);
 	GinSetNPosting(itup, nipd);
 

Original file line number	Diff line number	Diff line change
`@@ -87,6 +87,8 @@ GinFormTuple(GinState *ginstate,`
`87`	`87`	`newsize = Max(newsize, minsize);`
`88`	`88`	`}`
`89`	`89`
	`90`	`+ newsize = SHORTALIGN(newsize);`
	`91`	`+`
`90`	`92`	`GinSetPostingOffset(itup, newsize);`
`91`	`93`	`GinSetNPosting(itup, nipd);`
`92`	`94`