[ts plugin] nullable to null OR undefined

devdoomari · devdoomari3 · commit a293467de32e · 2020-08-11T18:19:17.000+09:00
diff --git a/py_type_extractor/plugins/typescript/Converter.py b/py_type_extractor/plugins/typescript/Converter.py
@@ -74,7 +74,7 @@ def __init__(
     def get_identifier(self, node: NodeType) -> str:
         # TODO: sanitize names!
         if isinstance(node, NoneNode):
-            return 'null'
+            return 'null | undefined'
         if isinstance(node, ClassFound):
             return node.name.replace('.', '__')
         if isinstance(node, FunctionFound):
diff --git a/py_type_extractor/plugins/typescript/__tests__/ts_fixtures/func_return_none.d.ts b/py_type_extractor/plugins/typescript/__tests__/ts_fixtures/func_return_none.d.ts
@@ -1,4 +1,4 @@
 export function func_return_none(
-    	some_input: string | null,
-    	some_input2: boolean | null,
+    	some_input: string | null | undefined,
+    	some_input2: boolean | null | undefined,
 ): any
diff --git a/py_type_extractor/plugins/typescript/__tests__/ts_fixtures/func_with_builtin_type_args.d.ts b/py_type_extractor/plugins/typescript/__tests__/ts_fixtures/func_with_builtin_type_args.d.ts
@@ -1,4 +1,4 @@
 export function func_with_builtin_type_args(
     a: number,
-	b: string | null,
+	b: string | null | undefined,
 ): number
