Exit the script process with non-zero status if at least one build was unsuccessful

m-aciek · m-aciek · commit ccc8d9998239 · 2023-03-12T01:55:56.000+01:00
diff --git a/build_docs.py b/build_docs.py
@@ -28,7 +28,7 @@
 import logging
 import logging.handlers
 from functools import total_ordering
-from os import readlink
+from os import readlink, EX_OK, EX_SOFTWARE
 import re
 import shlex
 import shutil
@@ -1044,7 +1044,7 @@ def purge_path(www_root: Path, path: Path):
     run(["curl", "-XPURGE", f"https://docs.python.org/{{{','.join(to_purge)}}}"])
 
 
-def main() -> None:
+def main() -> bool:
     """Script entry point."""
     args = parse_args()
     setup_logging(args.log_directory)
@@ -1054,6 +1054,7 @@ def main() -> None:
     del args.languages
     del args.branch
     todo = list(product(versions, languages))
+    all_built_successfully = True
     while todo:
         version, language = todo.pop()
         if sentry_sdk:
@@ -1063,7 +1064,7 @@ def main() -> None:
         try:
             lock = zc.lockfile.LockFile(HERE / "build_docs.lock")
             builder = DocBuilder(version, language, **vars(args))
-            builder.run()
+            all_built_successfully &= builder.run()
         except zc.lockfile.LockError:
             logging.info("Another builder is running... waiting...")
             time.sleep(10)
@@ -1078,6 +1079,9 @@ def main() -> None:
     dev_symlink(args.www_root, args.group)
     proofread_canonicals(args.www_root, args.skip_cache_invalidation)
 
+    return all_built_successfully
+
 
 if __name__ == "__main__":
-    main()
+    all_built_successfully = main()
+    sys.exit(EX_OK if all_built_successfully else EX_SOFTWARE)
