Fixes for sample code for ERA-OKID from Data-Driven Science and Engineering #1186
RPellowski
started this conversation in
General
Replies: 2 comments
-
|
Thanks for posting the fixes, I was struggling to get the OKID example working. Confirmed to still be valid with Python 3.13.3 and Control 0.10.2 |
Beta Was this translation helpful? Give feedback.
0 replies
-
|
Converting this to a discussion topic so that others can find it in the future. |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
-
What is the issue?
This code must have worked at one time but is now broken. Have no previous experience with it running correctly.
Two issues related to:
Notebook containing the broken code:
CH09_SEC03_ERA_OKID.ipynbSteps to Reproduce
Source changes to accommodate the failures
The following changes to the source were needed:
Issue 1. Slice assignment
Change
yFull[:,:,qi],t = impulse(sysFull,T=tspan,input=qi)to
yFull[:,:,qi:qi+1],t = impulse(sysFull,T=tspan,input=qi)Change
y1[:,:,qi],t1 = impulse(sysFull,np.arange(200),input=qi)y2[:,:,qi],t2 = impulse(sysERA,np.arange(100),input=qi)y3[:,:,qi],t3 = impulse(sysERAOKID,np.arange(100),input=qi)to
y1[:,:,qi:qi+1],t1 = impulse(sysFull,np.arange(200),input=qi)y2[:,:,qi:qi+1],t2 = impulse(sysERA,np.arange(100),input=qi)y3[:,:,qi:qi+1],t3 = impulse(sysERAOKID,np.arange(100),input=qi)Issue 2. Invalid np array shape
Change
yRandom = lsim(sysFull,uRandom,range(200))[0].T # Outputto
yRandom = lsim(sysFull,uRandom.T,range(200))[0].T # OutputSummary
Potential root causes could be due to changes in this library or in changes to Python or both.
Beta Was this translation helpful? Give feedback.
All reactions