Use Assembly.Load(Byte[]) instead of Assembly.LoadFrom.

tonyroberts · tonyroberts · commit b65fa30c7b21 · 2014-04-11T14:50:34.000+01:00
diff --git a/pythonnet/src/runtime/assemblymanager.cs b/pythonnet/src/runtime/assemblymanager.cs
@@ -30,6 +30,7 @@ internal class AssemblyManager {
         static ResolveEventHandler rhandler;
         static Dictionary<string, int> probed;
         static List<Assembly> assemblies;
+        static Dictionary<string, Assembly> loadedAssemblies;
         internal static List<string> pypath;
 
         private AssemblyManager() {}
@@ -46,6 +47,7 @@ internal static void Initialize() {
             probed = new Dictionary<string, int>(32);
             //generics = new Dictionary<string, Dictionary<string, string>>();
             assemblies = new List<Assembly>(16);
+            loadedAssemblies = new Dictionary<string, Assembly>();
             pypath = new List<string>(16);
 
             AppDomain domain = AppDomain.CurrentDomain;
@@ -202,7 +204,19 @@ public static Assembly LoadAssemblyPath(string name) {
             string path = FindAssembly(name);
             Assembly assembly = null;
             if (path != null) {
-                try   { assembly = Assembly.LoadFrom(path); }
+                if (loadedAssemblies.ContainsKey(path)) {
+                    return loadedAssemblies[path];
+                }
+                // Avoid using Assembly.LoadFrom as referenced assemblies that exist
+                // in the same path will be loaded directly from there, rather than
+                // using other versions already loaded. This is a problem if there
+                // is a Python.Runtime.dll in the same folder as the assembly being
+                // loaded, as that will result in two instances being loaded.
+                try   {
+                    byte[] bytes = System.IO.File.ReadAllBytes(path);
+                    assembly = Assembly.Load(bytes);
+                    loadedAssemblies[path] = assembly;
+                }
                 catch {}
             }
             return assembly;
