All finalizers are disabled until valid implementation. Helps to avoid non relevant CI build faults.

dse · dse · commit 085239291e53 · 2017-09-04T18:39:53.000+04:00
diff --git a/src/runtime/delegatemanager.cs b/src/runtime/delegatemanager.cs
@@ -195,6 +195,10 @@ public Dispatcher(IntPtr target, Type dtype)
 
         ~Dispatcher()
         {
+            // We needs to disable Finalizers until it's valid implementation.
+            // Current implementation can produce low probability floating bugs.
+            return;
+
             // Note: the managed GC thread can run and try to free one of
             // these *after* the Python runtime has been finalized!
             if (Runtime.Py_IsInitialized() > 0)
diff --git a/src/runtime/pyobject.cs b/src/runtime/pyobject.cs
@@ -1,4 +1,4 @@
-﻿using System;
+using System;
 using System.Collections;
 using System.Dynamic;
 using System.Linq.Expressions;
@@ -43,6 +43,10 @@ protected PyObject()
 
         ~PyObject()
         {
+            // We needs to disable Finalizers until it's valid implementation.
+            // Current implementation can produce low probability floating bugs.
+            return;
+
             Dispose();
         }
 
diff --git a/src/runtime/pyscope.cs b/src/runtime/pyscope.cs
@@ -1,4 +1,4 @@
-﻿using System;
+using System;
 using System.Linq;
 using System.Collections.Generic;
 using System.Dynamic;
@@ -527,6 +527,10 @@ public void Dispose()
 
         ~PyScope()
         {
+            // We needs to disable Finalizers until it's valid implementation.
+            // Current implementation can produce low probability floating bugs.
+            return;
+
             Dispose();
         }
     }
diff --git a/src/runtime/pythonexception.cs b/src/runtime/pythonexception.cs
@@ -57,6 +57,10 @@ public PythonException()
 
         ~PythonException()
         {
+            // We needs to disable Finalizers until it's valid implementation.
+            // Current implementation can produce low probability floating bugs.
+            return;
+
             Dispose();
         }
 

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-using System;`
	`1`	`+using System;`
`2`	`2`	`using System.Collections;`
`3`	`3`	`using System.Dynamic;`
`4`	`4`	`using System.Linq.Expressions;`
`@@ -43,6 +43,10 @@ protected PyObject()`
`43`	`43`
`44`	`44`	`~PyObject()`
`45`	`45`	`{`
	`46`	`+ // We needs to disable Finalizers until it's valid implementation.`
	`47`	`+ // Current implementation can produce low probability floating bugs.`
	`48`	`+ return;`
	`49`	`+`
`46`	`50`	`Dispose();`
`47`	`51`	`}`
`48`	`52`
Original file line number	Diff line number	Diff line change
`@@ -57,6 +57,10 @@ public PythonException()`
`57`	`57`
`58`	`58`	`~PythonException()`
`59`	`59`	`{`
	`60`	`+ // We needs to disable Finalizers until it's valid implementation.`
	`61`	`+ // Current implementation can produce low probability floating bugs.`
	`62`	`+ return;`
	`63`	`+`
`60`	`64`	`Dispose();`
`61`	`65`	`}`
`62`	`66`