handle ProcessExit event to avoid Python crash when CLR (in particular Mono) is unloaded before Python stops

lostmsu · lostmsu · commit 39af4cb92314 · 2021-05-21T16:08:05.000-07:00
diff --git a/setup.py b/setup.py
@@ -40,7 +40,7 @@ def initialize_options(self):
 
     def finalize_options(self):
         if self.dotnet_config is None:
-            self.dotnet_config = "release"
+            self.dotnet_config = "debug"
 
         build = self.distribution.get_command_obj("build")
         build.ensure_finalized()
diff --git a/src/runtime/pythonengine.cs b/src/runtime/pythonengine.cs
@@ -192,6 +192,7 @@ public static void Initialize(IEnumerable<string> args, bool setSysArgv = true,
 
             // Make sure we clean up properly on app domain unload.
             AppDomain.CurrentDomain.DomainUnload += OnDomainUnload;
+            AppDomain.CurrentDomain.ProcessExit += OnProcessExit;
 
             // The global scope gets used implicitly quite early on, remember
             // to clear it out when we shut down.
@@ -249,6 +250,11 @@ static void OnDomainUnload(object _, EventArgs __)
             Shutdown();
         }
 
+        static void OnProcessExit(object _, EventArgs __)
+        {
+            Shutdown();
+        }
+
         /// <summary>
         /// A helper to perform initialization from the context of an active
         /// CPython interpreter process - this bootstraps the managed runtime
@@ -319,6 +325,7 @@ public static void Shutdown(ShutdownMode mode)
             // If the shutdown handlers trigger a domain unload,
             // don't call shutdown again.
             AppDomain.CurrentDomain.DomainUnload -= OnDomainUnload;
+            AppDomain.CurrentDomain.ProcessExit -= OnProcessExit;
 
             PyScopeManager.Global.Clear();
             ExecuteShutdownHandlers();
diff --git a/src/runtime/runtime.cs b/src/runtime/runtime.cs
@@ -393,6 +393,10 @@ internal static void Shutdown(ShutdownMode mode)
                 {
                     Py_Finalize();
                 }
+                else
+                {
+                    PyGILState_Release(state);
+                }
             }
         }
 

Original file line number	Diff line number	Diff line change
`@@ -393,6 +393,10 @@ internal static void Shutdown(ShutdownMode mode)`
`393`	`393`	`{`
`394`	`394`	`Py_Finalize();`
`395`	`395`	`}`
	`396`	`+ else`
	`397`	`+ {`
	`398`	`+ PyGILState_Release(state);`
	`399`	`+ }`
`396`	`400`	`}`
`397`	`401`	`}`
`398`	`402`