respond to comments

koubaa · koubaa · commit 5fd8efc56094 · 2020-10-10T16:58:21.000-05:00
diff --git a/src/runtime/CollectionWrappers/IterableWrapper.cs b/src/runtime/CollectionWrappers/IterableWrapper.cs
@@ -30,6 +30,7 @@ public IEnumerator<T> GetEnumerator()
                     var item = Runtime.PyIter_Next(iterObject.Handle);
                     if (item == IntPtr.Zero)
                     {
+                        Runtime.CheckExceptionOccurred();
                         iterObject.Dispose();
                         break;
                     }
diff --git a/src/runtime/CollectionWrappers/SequenceWrapper.cs b/src/runtime/CollectionWrappers/SequenceWrapper.cs
@@ -56,6 +56,12 @@ public bool Contains(T item)
 
         public void CopyTo(T[] array, int arrayIndex)
         {
+            if (array == null)
+                throw new NullReferenceException();
+
+            if ((array.Length - arrayIndex) < this.Count)
+                throw new InvalidOperationException("Attempting to copy to an array that is too small");
+
             var index = 0;
             foreach (var item in this)
             {
@@ -69,9 +75,15 @@ protected bool removeAt(int index)
             if (IsReadOnly)
                 throw new NotImplementedException();
             if (index >= Count || index < 0)
-                throw new IndexOutOfRangeException();
+                return false;
+
+            var result = Runtime.PySequence_DelItem(pyObject.Handle, index);
 
-            return Runtime.PySequence_DelItem(pyObject.Handle, index) != 0;
+            if (result == 0)
+                return true;
+
+            Runtime.CheckExceptionOccurred();
+            return false;
         }
 
         protected int indexOf(T item)

Original file line number	Diff line number	Diff line change
`@@ -30,6 +30,7 @@ public IEnumerator<T> GetEnumerator()`
`30`	`30`	`var item = Runtime.PyIter_Next(iterObject.Handle);`
`31`	`31`	`if (item == IntPtr.Zero)`
`32`	`32`	`{`
	`33`	`+ Runtime.CheckExceptionOccurred();`
`33`	`34`	`iterObject.Dispose();`
`34`	`35`	`break;`
`35`	`36`	`}`