Add GetPrecedence reference

vmuriart · vmuriart · commit 6afc9e684856 · 2017-02-14T17:30:57.000-07:00
diff --git a/src/runtime/methodbinder.cs b/src/runtime/methodbinder.cs
@@ -167,11 +167,12 @@ internal MethodBase[] GetMethods()
         }
 
         /// <summary>
-        /// Precedence algorithm largely lifted from jython - the concerns are
-        /// generally the same so we'll start w/this and tweak as necessary.
+        /// Precedence algorithm largely lifted from Jython - the concerns are
+        /// generally the same so we'll start with this and tweak as necessary.
         /// </summary>
         /// <remarks>
-        /// TODO: Add link to specific Jython Section/Code/File
+        /// Based from Jython `org.python.core.ReflectedArgs.precedence`
+        /// See: https://github.com/jythontools/jython/blob/master/src/org/python/core/ReflectedArgs.java#L192
         /// </remarks>
         internal static int GetPrecedence(MethodBase mi)
         {
@@ -328,7 +329,7 @@ internal Binding Bind(IntPtr inst, IntPtr args, IntPtr kw, MethodBase info, Meth
                 else if (pynargs > clrnargs && clrnargs > 0 &&
                          Attribute.IsDefined(pi[clrnargs - 1], typeof(ParamArrayAttribute)))
                 {
-                    // This is a spam(params object[] egg) style method
+                    // This is a `foo(params object[] bar)` style method
                     match = true;
                     arrayStart = clrnargs - 1;
                 }

Original file line number	Diff line number	Diff line change
`@@ -167,11 +167,12 @@ internal MethodBase[] GetMethods()`
`167`	`167`	`}`
`168`	`168`
`169`	`169`	`/// <summary>`
`170`		`- /// Precedence algorithm largely lifted from jython - the concerns are`
`171`		`- /// generally the same so we'll start w/this and tweak as necessary.`
	`170`	`+ /// Precedence algorithm largely lifted from Jython - the concerns are`
	`171`	`+ /// generally the same so we'll start with this and tweak as necessary.`
`172`	`172`	`/// </summary>`
`173`	`173`	`/// <remarks>`
`174`		`- /// TODO: Add link to specific Jython Section/Code/File`
	`174`	+ /// Based from Jython `org.python.core.ReflectedArgs.precedence`
	`175`	`+ /// See: https://github.com/jythontools/jython/blob/master/src/org/python/core/ReflectedArgs.java#L192`
`175`	`176`	`/// </remarks>`
`176`	`177`	`internal static int GetPrecedence(MethodBase mi)`
`177`	`178`	`{`
`@@ -328,7 +329,7 @@ internal Binding Bind(IntPtr inst, IntPtr args, IntPtr kw, MethodBase info, Meth`
`328`	`329`	`else if (pynargs > clrnargs && clrnargs > 0 &&`
`329`	`330`	`Attribute.IsDefined(pi[clrnargs - 1], typeof(ParamArrayAttribute)))`
`330`	`331`	`{`
`331`		`- // This is a spam(params object[] egg) style method`
	`332`	+ // This is a `foo(params object[] bar)` style method
`332`	`333`	`match = true;`
`333`	`334`	`arrayStart = clrnargs - 1;`
`334`	`335`	`}`