when process is exiting, there's no need to save live .NET objects as they won't be resurrected

lostmsu · lostmsu · commit 8d61215d03c3 · 2021-12-27T10:33:36.000-08:00
diff --git a/src/runtime/pythonengine.cs b/src/runtime/pythonengine.cs
@@ -296,6 +296,7 @@ static void OnDomainUnload(object _, EventArgs __)
 
         static void OnProcessExit(object _, EventArgs __)
         {
+            Runtime.ProcessIsTerminating = true;
             Shutdown();
         }
 
diff --git a/src/runtime/runtime.cs b/src/runtime/runtime.cs
@@ -92,6 +92,7 @@ internal static int GetRun()
         }
 
         internal static bool HostedInPython;
+        internal static bool ProcessIsTerminating;
 
         /// Initialize the runtime...
         /// </summary>
@@ -254,7 +255,7 @@ internal static void Shutdown()
 
             var state = PyGILState_Ensure();
 
-            if (!HostedInPython)
+            if (!HostedInPython && !ProcessIsTerminating)
             {
                 // avoid saving dead objects
                 TryCollectingGarbage(runs: 3);

Original file line number	Diff line number	Diff line change
`@@ -296,6 +296,7 @@ static void OnDomainUnload(object _, EventArgs __)`
`296`	`296`
`297`	`297`	`static void OnProcessExit(object _, EventArgs __)`
`298`	`298`	`{`
	`299`	`+ Runtime.ProcessIsTerminating = true;`
`299`	`300`	`Shutdown();`
`300`	`301`	`}`
`301`	`302`
Original file line number	Diff line number	Diff line change
`@@ -92,6 +92,7 @@ internal static int GetRun()`
`92`	`92`	`}`
`93`	`93`
`94`	`94`	`internal static bool HostedInPython;`
	`95`	`+ internal static bool ProcessIsTerminating;`
`95`	`96`
`96`	`97`	`/// Initialize the runtime...`
`97`	`98`	`/// </summary>`
`@@ -254,7 +255,7 @@ internal static void Shutdown()`
`254`	`255`
`255`	`256`	`var state = PyGILState_Ensure();`
`256`	`257`
`257`		`- if (!HostedInPython)`
	`258`	`+ if (!HostedInPython && !ProcessIsTerminating)`
`258`	`259`	`{`
`259`	`260`	`// avoid saving dead objects`
`260`	`261`	`TryCollectingGarbage(runs: 3);`