disabled ability to register encoders for System.Type

lostmsu · lostmsu · commit 957a3cba8295 · 2021-03-30T21:10:07.000-07:00
Without this restriction encoders created in Python cause stack overflow due to repeated attempts to pass `System.Type` instance to `CanDecode`, which requires encoding the instance of `System.Type`, et. cetera fixes #1427
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -44,6 +44,7 @@ One must now either use enum members (e.g. `MyEnum.Option`), or use enum constru
 -   Sign Runtime DLL with a strong name
 -   Implement loading through `clr_loader` instead of the included `ClrModule`, enables
     support for .NET Core
+-   BREAKING: custom encoders are no longer called for instances of `System.Type`
 
 ### Fixed
 
diff --git a/src/runtime/converter.cs b/src/runtime/converter.cs
@@ -146,8 +146,11 @@ internal static IntPtr ToPython(object value, Type type)
                 return result;
             }
 
-            if (Type.GetTypeCode(type) == TypeCode.Object && value.GetType() != typeof(object)
-                || type.IsEnum) {
+            if (Type.GetTypeCode(type) == TypeCode.Object
+                && value.GetType() != typeof(object)
+                && value is not Type
+                || type.IsEnum
+            ) {
                 var encoded = PyObjectConversions.TryEncode(value, type);
                 if (encoded != null) {
                     result = encoded.Handle;
