allow user-created instances of PySequence and PyIterable

lostmsu · lostmsu · commit c1653f51d5b7 · 2021-10-01T17:12:40.000-07:00
diff --git a/src/runtime/pyiterable.cs b/src/runtime/pyiterable.cs
@@ -13,6 +13,18 @@ internal PyIterable(IntPtr ptr) : base(ptr)
         internal PyIterable(BorrowedReference reference) : base(reference) { }
         internal PyIterable(in StolenReference reference) : base(reference) { }
 
+        /// <summary>
+        /// Creates new instance from an existing object.
+        /// </summary>
+        /// <remarks>This constructor does not check if <paramref name="o"/> is actually iterable.</remarks>
+        public PyIterable(PyObject o) : base(FromObject(o)) { }
+
+        static BorrowedReference FromObject(PyObject o)
+        {
+            if (o is null) throw new ArgumentNullException(nameof(o));
+            return o.Reference;
+        }
+
         /// <summary>
         /// Return a new PyIter object for the object. This allows any iterable
         /// python object to be iterated over in C#. A PythonException will be
diff --git a/src/runtime/pysequence.cs b/src/runtime/pysequence.cs
@@ -1,3 +1,4 @@
+#nullable enable
 using System;
 
 namespace Python.Runtime
@@ -14,6 +15,18 @@ public class PySequence : PyIterable
         internal PySequence(BorrowedReference reference) : base(reference) { }
         internal PySequence(in StolenReference reference) : base(reference) { }
 
+        /// <summary>
+        /// Creates new instance from an existing object.
+        /// </summary>
+        /// <exception cref="ArgumentException"><paramref name="o"/> does not provide sequence protocol</exception>
+        public PySequence(PyObject o) : base(FromObject(o)) { }
+
+        static BorrowedReference FromObject(PyObject o)
+        {
+            if (o is null) throw new ArgumentNullException(nameof(o));
+            if (!IsSequenceType(o)) throw new ArgumentException("object is not a sequence");
+            return o.Reference;
+        }
 
         /// <summary>
         /// Returns <c>true</c> if the given object implements the sequence protocol.
