Use PyThreadState_GetUnchecked on Python 3.13

filmor · filmor · commit f3face061ac4 · 2024-12-11T18:12:15.000+01:00
diff --git a/src/runtime/Runtime.Delegates.cs b/src/runtime/Runtime.Delegates.cs
@@ -25,11 +25,14 @@ static Delegates()
             PyThreadState_Get = (delegate* unmanaged[Cdecl]<PyThreadState*>)GetFunctionByName(nameof(PyThreadState_Get), GetUnmanagedDll(_PythonDll));
             try
             {
-                _PyThreadState_UncheckedGet = (delegate* unmanaged[Cdecl]<PyThreadState*>)GetFunctionByName(nameof(_PyThreadState_UncheckedGet), GetUnmanagedDll(_PythonDll));
+                // Up until Python 3.13, this function was private and named
+                // slightly differently.
+                PyThreadState_GetUnchecked = (delegate* unmanaged[Cdecl]<PyThreadState*>)GetFunctionByName("_PyThreadState_UncheckedGet", GetUnmanagedDll(_PythonDll));
             }
             catch (MissingMethodException)
             {
-                // Not supported in Python 3.13 anymore
+
+                PyThreadState_GetUnchecked = (delegate* unmanaged[Cdecl]<PyThreadState*>)GetFunctionByName(nameof(PyThreadState_GetUnchecked), GetUnmanagedDll(_PythonDll));
             }
             try
             {
@@ -320,7 +323,7 @@ static Delegates()
         internal static delegate* unmanaged[Cdecl]<PyThreadState*, void> Py_EndInterpreter { get; }
         internal static delegate* unmanaged[Cdecl]<PyInterpreterState*, PyThreadState*> PyThreadState_New { get; }
         internal static delegate* unmanaged[Cdecl]<PyThreadState*> PyThreadState_Get { get; }
-        internal static delegate* unmanaged[Cdecl]<PyThreadState*> _PyThreadState_UncheckedGet { get; }
+        internal static delegate* unmanaged[Cdecl]<PyThreadState*> PyThreadState_GetUnchecked { get; }
         internal static delegate* unmanaged[Cdecl]<int> PyGILState_Check { get; }
         internal static delegate* unmanaged[Cdecl]<PyGILState> PyGILState_Ensure { get; }
         internal static delegate* unmanaged[Cdecl]<PyGILState, void> PyGILState_Release { get; }
diff --git a/src/runtime/Runtime.cs b/src/runtime/Runtime.cs
@@ -316,7 +316,7 @@ internal static void Shutdown()
                 // Then release the GIL for good, if there is somehting to release
                 // Use the unchecked version as the checked version calls `abort()`
                 // if the current state is NULL.
-                if (_PyThreadState_UncheckedGet() != (PyThreadState*)0)
+                if (PyThreadState_GetUnchecked() != (PyThreadState*)0)
                 {
                     PyEval_SaveThread();
                 }
@@ -705,7 +705,7 @@ internal static T TryUsingDll<T>(Func<T> op)
         internal static PyThreadState* PyThreadState_Get() => Delegates.PyThreadState_Get();
 
 
-        internal static PyThreadState* _PyThreadState_UncheckedGet() => Delegates._PyThreadState_UncheckedGet();
+        internal static PyThreadState* PyThreadState_GetUnchecked() => Delegates.PyThreadState_GetUnchecked();
 
 
         internal static int PyGILState_Check() => Delegates.PyGILState_Check();

Original file line number	Diff line number	Diff line change
`@@ -25,11 +25,14 @@ static Delegates()`
`25`	`25`	`PyThreadState_Get = (delegate* unmanaged[Cdecl]<PyThreadState*>)GetFunctionByName(nameof(PyThreadState_Get), GetUnmanagedDll(_PythonDll));`
`26`	`26`	`try`
`27`	`27`	`{`
`28`		`- _PyThreadState_UncheckedGet = (delegate* unmanaged[Cdecl]<PyThreadState*>)GetFunctionByName(nameof(_PyThreadState_UncheckedGet), GetUnmanagedDll(_PythonDll));`
	`28`	`+ // Up until Python 3.13, this function was private and named`
	`29`	`+ // slightly differently.`
	`30`	`+ PyThreadState_GetUnchecked = (delegate* unmanaged[Cdecl]<PyThreadState*>)GetFunctionByName("_PyThreadState_UncheckedGet", GetUnmanagedDll(_PythonDll));`
`29`	`31`	`}`
`30`	`32`	`catch (MissingMethodException)`
`31`	`33`	`{`
`32`		`- // Not supported in Python 3.13 anymore`
	`34`	`+`
	`35`	`+ PyThreadState_GetUnchecked = (delegate* unmanaged[Cdecl]<PyThreadState*>)GetFunctionByName(nameof(PyThreadState_GetUnchecked), GetUnmanagedDll(_PythonDll));`
`33`	`36`	`}`
`34`	`37`	`try`
`35`	`38`	`{`
`@@ -320,7 +323,7 @@ static Delegates()`
`320`	`323`	`internal static delegate* unmanaged[Cdecl]<PyThreadState*, void> Py_EndInterpreter { get; }`
`321`	`324`	`internal static delegate* unmanaged[Cdecl]<PyInterpreterState, PyThreadState> PyThreadState_New { get; }`
`322`	`325`	`internal static delegate* unmanaged[Cdecl]<PyThreadState*> PyThreadState_Get { get; }`
`323`		`- internal static delegate* unmanaged[Cdecl]<PyThreadState*> _PyThreadState_UncheckedGet { get; }`
	`326`	`+ internal static delegate* unmanaged[Cdecl]<PyThreadState*> PyThreadState_GetUnchecked { get; }`
`324`	`327`	`internal static delegate* unmanaged[Cdecl]<int> PyGILState_Check { get; }`
`325`	`328`	`internal static delegate* unmanaged[Cdecl]<PyGILState> PyGILState_Ensure { get; }`
`326`	`329`	`internal static delegate* unmanaged[Cdecl]<PyGILState, void> PyGILState_Release { get; }`
Original file line number	Diff line number	Diff line change
`@@ -316,7 +316,7 @@ internal static void Shutdown()`
`316`	`316`	`// Then release the GIL for good, if there is somehting to release`
`317`	`317`	// Use the unchecked version as the checked version calls `abort()`
`318`	`318`	`// if the current state is NULL.`
`319`		`- if (_PyThreadState_UncheckedGet() != (PyThreadState*)0)`
	`319`	`+ if (PyThreadState_GetUnchecked() != (PyThreadState*)0)`
`320`	`320`	`{`
`321`	`321`	`PyEval_SaveThread();`
`322`	`322`	`}`
`@@ -705,7 +705,7 @@ internal static T TryUsingDll<T>(Func<T> op)`
`705`	`705`	`internal static PyThreadState* PyThreadState_Get() => Delegates.PyThreadState_Get();`
`706`	`706`
`707`	`707`
`708`		`- internal static PyThreadState* _PyThreadState_UncheckedGet() => Delegates._PyThreadState_UncheckedGet();`
	`708`	`+ internal static PyThreadState* PyThreadState_GetUnchecked() => Delegates.PyThreadState_GetUnchecked();`
`709`	`709`
`710`	`710`
`711`	`711`	`internal static int PyGILState_Check() => Delegates.PyGILState_Check();`