-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Closed
Description
Feature Request
Looking at Pool class we can improve it in some ways, these are my thoughts:
- Extract
title,logoandoptionsto aConfigurationclass, these parameters are used as configuration for the whole project, they shouldn't be needed for instantiate a Pool. Introduce SonataConfiguration class #6640 - Remove PropertyAccessor, it was added for reuse, but after that cache was added to the component, so we can remove it and inject PropertyAccessor where is needed. Deprecate Pool::getPropertyAccessor() method #6634
- Inject a
ServiceLocatorwith only the admin services, so we wouldn't need them to be public. Inject a ServiceLocator to Pool instead of container #6733
After this the Pool class would be use just a registry for admin classes which I think it was meant to be.
The last one I guess it cannot be done with BC, but the other two we can deprecate those parameters in the Pool class.
WDYT? @sonata-project/contributors
phansys, VincentLanglet, wbloszyk and OskarStark