sponsorship form: fix rendering of application form

ewdurbin · ewdurbin · commit 88d42f786f85 · 2023-03-18T08:19:52.000-04:00
When benefits are configured for packages that are to the right of
packages that *do not* have a benefit, we should correctly render.

This was effectively "gravity left" for the icons on the application.
diff --git a/templates/sponsors/sponsorship_benefits_form.html b/templates/sponsors/sponsorship_benefits_form.html
@@ -96,7 +96,7 @@ <h4 class="benefit-title">{{ benefit.name }}</h4>
           <!-- Packages information (as columns) --!>
           {% for package in form.fields.package.queryset %}
             <div class="col benefit-within-package {% if forloop.counter <= benefit.num_packages or not benefit.package_only %}package-{{ package.id }}-benefit {% if form.initial.package == package.id %}selected{% endif %}{% endif %}" data-package-reference="{{ package.id }}">
-              {% if forloop.counter <= benefit.num_packages %}
+              {% if benefit in package.benefits.all %}
                 <img
                     id="benefit-{{ benefit.id }}-package-{{ package.id }}"
                     onclick="benefitUpdate({{ benefit.id }}, {{ package.id }})"
