feature #61413 [Serializer] Make AttributeMetadata and ClassMetadata final (nicolas-grekas)

nicolas-grekas · nicolas-grekas · commit 52bd4c6207bd · 2025-08-14T13:43:42.000+02:00
This PR was merged into the 7.4 branch. Discussion ---------- [Serializer] Make `AttributeMetadata` and `ClassMetadata` final | Q | A | ------------- | --- | Branch? | 7.4 | Bug fix? | no | New feature? | yes | Deprecations? | yes | Issues | - | License | MIT One more PR to get rid of sleep/wakeup in 8.0 Commits ------- 727aaac [Serializer] Make `AttributeMetadata` and `ClassMetadata` final
diff --git a/UPGRADE-7.4.md b/UPGRADE-7.4.md
@@ -59,6 +59,11 @@ Security
  * Deprecate `AbstractListener::__invoke`
  * Deprecate `LazyFirewallContext::__invoke()`
 
+Serializer
+----------
+
+ * Make `AttributeMetadata` and `ClassMetadata` final
+
 Translation
 -----------
 
diff --git a/src/Symfony/Component/Serializer/CHANGELOG.md b/src/Symfony/Component/Serializer/CHANGELOG.md
@@ -6,6 +6,7 @@ CHANGELOG
 
  * Add `CDATA_WRAPPING_NAME_PATTERN` support to `XmlEncoder`
  * Add support for `can*()` methods to `AttributeLoader`
+ * Make `AttributeMetadata` and `ClassMetadata` final
 
 7.3
 ---
diff --git a/src/Symfony/Component/Serializer/Mapping/AttributeMetadata.php b/src/Symfony/Component/Serializer/Mapping/AttributeMetadata.php
@@ -15,6 +15,8 @@
 
 /**
  * @author Kévin Dunglas <dunglas@gmail.com>
+ *
+ * @final since Symfony 7.4
  */
 class AttributeMetadata implements AttributeMetadataInterface
 {
@@ -215,9 +217,9 @@ public function merge(AttributeMetadataInterface $attributeMetadata): void
     }
 
     /**
-     * Returns the names of the properties that should be serialized.
+     * @internal since Symfony 7.4, will be replaced by `__serialize()` in 8.0
      *
-     * @return string[]
+     * @final since Symfony 7.4
      */
     public function __sleep(): array
     {
diff --git a/src/Symfony/Component/Serializer/Mapping/ClassMetadata.php b/src/Symfony/Component/Serializer/Mapping/ClassMetadata.php
@@ -13,6 +13,8 @@
 
 /**
  * @author Kévin Dunglas <dunglas@gmail.com>
+ *
+ * @final since Symfony 7.4
  */
 class ClassMetadata implements ClassMetadataInterface
 {
@@ -92,9 +94,9 @@ public function setClassDiscriminatorMapping(?ClassDiscriminatorMapping $mapping
     }
 
     /**
-     * Returns the names of the properties that should be serialized.
+     * @internal since Symfony 7.4, will be replaced by `__serialize()` in 8.0
      *
-     * @return string[]
+     * @final since Symfony 7.4
      */
     public function __sleep(): array
     {

Original file line number	Diff line number	Diff line change
`@@ -15,6 +15,8 @@`
`15`	`15`
`16`	`16`	`/**`
`17`	`17`	`* @author Kévin Dunglas <dunglas@gmail.com>`
	`18`	`+ *`
	`19`	`+ * @final since Symfony 7.4`
`18`	`20`	`*/`
`19`	`21`	`class AttributeMetadata implements AttributeMetadataInterface`
`20`	`22`	`{`
`@@ -215,9 +217,9 @@ public function merge(AttributeMetadataInterface $attributeMetadata): void`
`215`	`217`	`}`
`216`	`218`
`217`	`219`	`/**`
`218`		`- * Returns the names of the properties that should be serialized.`
	`220`	+ * @internal since Symfony 7.4, will be replaced by `__serialize()` in 8.0
`219`	`221`	`*`
`220`		`- * @return string[]`
	`222`	`+ * @final since Symfony 7.4`
`221`	`223`	`*/`
`222`	`224`	`public function __sleep(): array`
`223`	`225`	`{`
Original file line number	Diff line number	Diff line change
`@@ -13,6 +13,8 @@`
`13`	`13`
`14`	`14`	`/**`
`15`	`15`	`* @author Kévin Dunglas <dunglas@gmail.com>`
	`16`	`+ *`
	`17`	`+ * @final since Symfony 7.4`
`16`	`18`	`*/`
`17`	`19`	`class ClassMetadata implements ClassMetadataInterface`
`18`	`20`	`{`
`@@ -92,9 +94,9 @@ public function setClassDiscriminatorMapping(?ClassDiscriminatorMapping $mapping`
`92`	`94`	`}`
`93`	`95`
`94`	`96`	`/**`
`95`		`- * Returns the names of the properties that should be serialized.`
	`97`	+ * @internal since Symfony 7.4, will be replaced by `__serialize()` in 8.0
`96`	`98`	`*`
`97`		`- * @return string[]`
	`99`	`+ * @final since Symfony 7.4`
`98`	`100`	`*/`
`99`	`101`	`public function __sleep(): array`
`100`	`102`	`{`